Posted by Summit on March 2, 2013 at 10:15pm
3 followers
Jump to:
| Project: | Drupal Commons |
| Version: | 7.x-3.x-dev |
| Component: | Theme |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | postponed (maintainer needs more info) |
| Issue tags: | Commons 7.x-3.1 radar |
Issue Summary
Hi,
See Image, when I place something in the Welcome Text it is very large and aligned to the right, instead of just coffering the whole area.
Thanks a lot in advance for going into this.
Greetings,
Martijn
| Attachment | Size |
|---|---|
| commons_theming.jpg | 38.38 KB |
Comments
#1
Hi,
I found the cullpit:
In responsive.custom.css
/** Tablet sizes and up
*/
@media only screen and (min-width: 768px) {
body.front.not-logged-in #content {
background: url('../images/commons-drop.png?1361802894') right top no-repeat;
}
body.front.not-logged-in .region-three-33-top {
margin-bottom: 24px;
min-height: 100px; <=== changed this to have myself control about the height above 100px.
}
body.front.not-logged-in #block-system-main .pane-1 {
float: left;
width: 56%;
}
body.front.not-logged-in #block-system-main .pane-2 {
float: right; <==== This is the cullpit
width: 40%;
}
}
I changed:
body.front.not-logged-in #block-system-main .pane-2 {float: left; <==== This is changed
width: 40%;
}
Why are those settings in the theme and not just using the panels layout?
Greetings, Martijn
#2
Marking as "needs review".
Can you specify the browser where you're seeing this?
#3
I am having trouble replicating this. I initially thought that your text had been put in the wrong pane, but I am not seeing a way to do so. I agree that we can likely do something with the CSS there, but there seems to be a deeper issue at work with your specific problem. In the default layout, the text should appear in the pane using the styling above the one you are pointing at.
Can you give us a walkthrough of the steps you took to edit this text?
#4
#5
Hi,
may be I am misunderstood, sorry for that.
I see in the file I am referring to hardcoded the theme settings in responsive.custom.css like: float left, float right and min-height.
And of course these panes are then set accordingly.
But when you think, like with a other themes I have played with you could alter these settings only with the panele ui it is not working because of these hardcoded floats and height fix in the theme,
Greetings, Martijn