Allow us to set the target link such as _blank , _self etc.

CommentFileSizeAuthor
#2 TargetLink-1932396-2.patch3.37 KBaadityawalawalkar

Comments

strikehawkecomm’s picture

strikehawkecomm commented
Component: User interface » Code
Issue tags: +target _blank
aadityawalawalkar’s picture

aadityawalawalkar commented
Status: Active » Needs review
StatusFileSize
new TargetLink-1932396-2.patch3.37 KB

Please find the patch to add a new target link select box that allows to set the target link window (Same or New Window option).
The target link select can be set at "/admin/config/services/follow". By default it is set to Same Window.
I have also fixed the test (follow/tests/follow.test) which failed on my setup with and without my changes.
The patch also for the test is included in the patch attached.

xuxizh’s picture

xuxizh commented

Hello,there,
when I tried to apply this patch to the latest 7.x-2.x-dev, I got below errors.

$ git apply --check TargetLink-1932396-2.patch
error: patch failed: follow.module:389
error: follow.module: patch does not apply

What's wrong with my command ?

astonvictor’s picture

astonvictor commented
Issue summary: View changes
Status: Needs review » Closed (outdated)

I'm closing it because the issue was created a long time ago without any further steps.

if you still need it then raise a new one.
thanks