Add support for link fields (externally hosted audio files)
nedjo - November 18, 2007 - 17:26
| Project: | Mediafield Display |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | nedjo |
| Status: | closed |
Jump to:
Description
Attached patch adds support for link fields. Allows posting of audio files on an external site (e.g., archive.org) and then displaying them for playing locally. Builds off the link field for its existing handling of URLs.
Does this fit in the mediafield_display module? I'm concerned that it complicates the code (adds a lot that's specific to link handling). Should it be a separate module? Or is this functionality better put elsewhere?
| Attachment | Size |
|---|---|
| mediafield_display-link.patch | 6.24 KB |
#1
I think it may make more sense to add this functionality to Media Field because that module is the one that's responsible for content. In theory, all this display module should do is show a player, which it already does. That's just a first thought. I'll think about it some more.
What do you think about moving this over there?
#2
Thanks for looking at this.
The patch is purely about display. Currently the module supports displaying a single kind of field: file_audio. The patch would add support for a second field type, link, defined by the Link module, http://drupal.org/project/link.
<?php- 'field types' => array('file_audio'),
+ 'field types' => array('file_audio', 'link'),
?>
Admins would add a link field to a content type, selecting one of the players for display.
So it's unrelated to mediafield. That's part of why I'm not completely sure that it fits with mediafield_display.
#3
I haven't been able to come up with a better idea for where to put this, so let's just stick it in. It can be part of the official 5.x release, which is still on my to-do list. Hopefully I'll get around to that before D6 comes out. ;)
#4
Committed in 5 and HEAD.
#5
Automatically closed -- issue fixed for two weeks with no activity.