Tested with currencies other than EUR on Winbank test environment. All amounts were considered (by the Paycenter?) to be in EUR (without proper currency rate conversion) even though the selected user currency on the site was USD or GBP. This may have to do with Premium vs non-premium Winbank accounts (Premium supports multi-currency).

Does the current module send only EUR (code = 978) to the ticketing service?

Considering 25 EUR to be = 25 USD is a very serious problem...

Comments

bserem’s picture

bserem commented
Status: Active » Closed (works as designed)

The Winbank module supports only Euros at the moment.

This is subject to change in the future. I would like to have it ready by RC1 or version 1.0-final if I can.

marktheshark’s picture

marktheshark commented
Status: Closed (works as designed) » Needs work

Could the module do at least this for the time being to align itself with e.g. the Paypal module?

Send the original price in the default currency, even though the user currency may be different.

Otherwise the admin has to switch off multi-currency on the site entirely.

bserem’s picture

bserem commented
Status: Needs work » Closed (works as designed)

No, of course not, we do not want to mix this with the paypal module for any reason.
They are something completely different.

If you want to speed things up you can always help with a patch for multi-currency.
We have plans for it ourselves in the future though.

marktheshark’s picture

marktheshark commented

Well, imho I don't see that the Paypal logic is irrelevant.

Normally payment modules should allow the admin to set if the amount sent to the payment GW will be in the default currency or the user currency. The Paypal module does actually allow the admin to choose this.

Note that always sending EUR would be the best option for not even needing a Premium Winbank Account.

Currently the customer:

  • Can make a purchase in USD via Paypal, because the Paypal module will send EUR by default
  • Cannot make a purchase in USD via Winbank, because the price will be wrong

This is a major problem. The admin either needs to disable multi-currency altogether or create rules that won't make Winbank redirection available when the currency is non-EUR.

msti’s picture

msti
Location Heraklion
commented

It is not the module's job to make currency conversion. You should implement a way to send the correct amount of EUR to the module. Or deactivate this payment method for currency other than EUR.

marktheshark’s picture

marktheshark commented

Without having examined the Paypal module source, I am guessing that PP just uses the default price (no actual conversion based on exchange rates).

If not, do you consider it to be a bug in the multi-currency module?

xaris.tsimpouris’s picture

xaris.tsimpouris commented
Category: support » feature
Status: Closed (works as designed) » Closed (fixed)

Apparently this cannot be assumed as a bug, as this payment method is targeted to a Greek bank.
New commit (fd8124d) now supports currency setting.
Now you can create two payment rules for multi-currency sites and activate the one that fits your needs (activate USD or EUR in whatever case).
In order to work on an existing installation, please open, check and save again your payment rules.

marktheshark’s picture

marktheshark commented

It would be useful to have a note in the main module page and / or documentation that by default the module assumes EUR as the default currency so that the admin does not run into any surprises.

I will try your new commit once it is available (I assume the commit has not reached the published releases yet), thank you.

xaris.tsimpouris’s picture

xaris.tsimpouris commented
Assigned: Unassigned » xaris.tsimpouris

I have confirmed that winbank changes currency (is is shown above credit card form).
However, please confirm.
I am not happy with the idea that somebody is based on defaults for a payment center. Anyway, @bserem let's find a way to write it down, shall we?

bserem’s picture

bserem commented

I am a fun of the README file and the module description page, isn't this enough?

marktheshark’s picture

marktheshark commented

I have installed this update. Out of 3 available currencies (EUR, USD, GBP), the module settings listed only 2 (EUR, USD).

xaris.tsimpouris’s picture

xaris.tsimpouris commented

"Out of 3 available currencies" according to which WinBank Redirection Manual?

marktheshark’s picture

marktheshark commented

The redirection manual, at least version 1.0.4, it mentions only euros are supported, however if one is a Paycenter Premium customer there is supposed to be multi-currency support, or not?

marktheshark’s picture

marktheshark commented

For what it's worth, there are some guidelines for Payment module developers issued by the multicurrency module dev:

http://www.drupalcommerce.org/discussions/7670/design-pattern-payment-ga...

Might be useful as a reference.

marktheshark’s picture

marktheshark commented
Issue summary: View changes

details