Closed (fixed)
Project:
Views Responsive Grid
Version:
7.x-1.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
4 Mar 2013 at 09:35 UTC
Updated:
12 Jul 2013 at 04:21 UTC
Jump to comment: Most recent file
Comments
Comment #1
iwhitcomb commentedYeah, that'd be great.
Comment #2
derhasi commentedAs suggested in the core issue, I'd try to port this module to D8 and then look, what parts we can suggest for core.
Comment #3
derhasi commentedThere's a first patch that seems to work fine on my local drupal 8 dev.
@Ian, I've split up the whole patch in several commits in my local repos, so maybe (if you like) I'd open a sandbox or may get access to this module's repo, so I can directly push the history.
Comment #4
derhasi commentedbtw: there currently is a core bug that prevents relying on views theme handling: #1911492: Views try to find Custom StylePlugin template in core/modules/views/templates. Therefore the hook_theme_registry_alter() had to be implemented.
Comment #5
mgiffordPatch applies nicely. Haven't been able to test the module though as Core is failing on me right now.
Comment #6
mgiffordOk, I finally remembered to nix the /c directory that is now getting created in D8. Then went to re-install and everything went fine.
After installing the updated Views Responsive Grid in D8 though I couldn't get it to show up in more than one column. Played around with it a bit, but wasn't able to get it to do anything in 3-4 columns. I might have to read the docs.....
Anyways, also ran into this PHP warning:
Comment #7
iwhitcomb commentedderhasi - I applied your patch in the 8.x-1.x branch and made you a maintainer
Comment #8
markhalliwellCommitted to the 8.x-1.x branch: b8478cc.
This is just in-case #1903746-42: Replace the views grid table template with one using divs doesn't make the cut.