Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Thanks to all the e-Commerce developers!
Attached patch will:
1) Throw appropriate messages when test fails/succeds. Not very useful for debugging, but it gets the point across.
2) Trim whitespace from submitted URLs.
ecommerce/contrib/shipcalc/partners/usps.inc
If there is a better place to post this, please let me know.
Comment | File | Size | Author |
---|---|---|---|
#3 | FROM_CVS-usps_inc.patch | 1.8 KB | Jim Phlew |
#1 | WORKS_ec_contrib_shipcalc_partners_usps.inc_.patch | 1.65 KB | Jim Phlew |
ec_contrib_shipcalc_partners_usps.inc_.patch | 1.65 KB | Jim Phlew | |
Comments
Comment #1
Jim Phlew CreditAttribution: Jim Phlew commentedwas hasty with patch post. first patch has extraneous ` and will break things.
Fixed patch attached here.
Comment #2
mo6The patch doesn't apply. Could you please recreate the patch doing a cvs diff against 5.x-3.4? Thanks.
http://drupal.org/patch/create
Comment #3
Jim Phlew CreditAttribution: Jim Phlew commentedmaybe this time, against CVS DRUPAL-5--3-4
Comment #4
Jim Phlew CreditAttribution: Jim Phlew commentedThis is a bug in my opinion. The original code does not give the user any indication of success or failure when testing. There is code for throwing a message, but in my experience with the original code one is never thrown. Had to use tcpdump to troubleshoot. The patch just corrects the simple pass/fail indication of the test. If these were adding some serious debugging code, then maybe it would be a feature request.
Whitspace trim is also a bug because if one uses a url with whitespace, the test and shipping calculations will not work. Again one must use tcpdump to watch the interaction with the remote host and see the responses nothing is shown in the web browser to indicate that there is a problem.
Comment #5
mike15 CreditAttribution: mike15 commentedIs there any plans on adding this fix to a future 5.x-4.x release?
Thanks.
Comment #6
Jim Phlew CreditAttribution: Jim Phlew commentedI don't have a 4.x testbed to debug a port attempt. Maybe someone else can help with that. Should be quick, not many lines were changed in the 3.4 patch, but the again I haven't looked at the 4.x code.
Comment #7
brmassa CreditAttribution: brmassa commentedGuys,
its fixed on eC4 CVS.
regards,
massa
Comment #8
(not verified) CreditAttribution: commentedAutomatically closed -- issue fixed for two weeks with no activity.