i'm not sure if this is the correct place to ask this but perhaps you can point me in the right direction. i've been struggling with these issues for a while and haven't been able to get past them.

the first is, line breaks in plain text nodes don't seem to be interpretted in the body of the feed items. auto generated teasers look fine. i have tried using the standard full html input format as well as a simple custom format (along with a module which allows me to apply the new type to feed items only) which filters html and applies line breaks. i've tried reordering the filters with no luck. i'm using a standard garland theme with no custom tpl's.

the second problem is, if a feed includes a lot of html, the auto generated teasers tend to chop the html in bad places causing them to break the display. this problem must be quite common.

thanks for any direction you can provide.

CommentFileSizeAuthor
#2 themeissue.png14.91 KBron collins

Comments

Ashraf Amayreh’s picture

Ashraf Amayreh commented
Assigned: Unassigned » Ashraf Amayreh
Status: Active » Postponed (maintainer needs more info)

Could you provide the URL to the feed? Or if not possible, attach a sample here so I can take a quick look?

ron collins’s picture

ron collins commented
StatusFileSize
new themeissue.png14.91 KB

problem 1

this post is plain text only in the body: http://mostlywater.org/en_canada_alt_media_oon_edmonton_anarchist_bookfa...

you can see its teaser on the front page. the teaser formating looks fine. when editing, the body content in the form reflects the line breaks in the database. the problem is in the rendering layer.

if you want to see it with a default garland theme, you can create an account, log in and switch. but it looks the same.

i have attached a screenshot of the preview of another feed item to show the comparison. in that node, each word "test" should appear on a new line.

problem 2

i have gotten around this problem for now by using a table view with the title only. no teaser. if you think there is something you might gain by looking at this, i can put it back temporarily for you.

this isn't the best example, but the teaser text can look like this:

<a href="/video/noam-chomsky-on-iran"><img src="http://coanews.org/sites/coanews.org/files/images/chomsky2.gif" alt="" title="" class="image thumbnail video_image_teaser" width="139" height="148" /></a><p>Are assumptions about Iran wrong?

in this case, the paragraph marker isn't closed. not the end of the world. but when an image tag or anchor or div doesn't close, it can really make a mess of things.

if you need more access to see what's happening with either of these problems, let me know.

vito_swat’s picture

vito_swat commented

To solve problem 2 check htmlcorrector module. It's a known bug in drupal and D6 will have htmlcorrector in core.

ron collins’s picture

ron collins commented

thanks. issue 2 is much better. issue 1 is still a problem. any ideas where to dig further?

ron collins’s picture

ron collins commented
Status: Postponed (maintainer needs more info) » Active

more info...

i noticed that aggregation_item nodes just don't acknowledge any of the input filter formatting. if i create a new input format using just the "URL filter" to convert url strings to links, there is no change in the output. no URL's are converted. they are simply printed as plain text.

isn't anyone else having this problem? has it never been reported before? i don't understand what is distinguishing these nodes from other node types on my system. the body is being stored in the node_revisions table just like other nodes so why should it be treated differently?

ron collins’s picture

ron collins commented

unfortunately, i'm going to have to look at other aggregation options at this point. i can't just keep going with the formatting the way it is.

ron collins’s picture

ron collins commented

this seems related: http://drupal.org/node/201383

again, the lack of format filters only happens in the full node view. teasers are fine. if i edit the feed_items and insert html, it is interpreted correctly.

selectsplat’s picture

selectsplat commented

Any updates on issue#1?

selectsplat’s picture

selectsplat commented

Grrr.

Why was this thread deleted?
http://drupal.org/node/201383

Ashraf Amayreh’s picture

Ashraf Amayreh commented

Fixed, but I'm waiting to accumulate more bug fixes before creating a release.

Ashraf Amayreh’s picture

Ashraf Amayreh commented
Status: Active » Closed (fixed)

I'm thinking of creating a release by next Saturday the 22nd even if it's with this fix only. So that's when you can expect it.

selectsplat’s picture

selectsplat commented

Outstanding. Please be sure to include information on how to make a donation for your work. Is there any way you can post the code changes here so that I can apply them (I am a php hobbyist) before next week?

Thanks in advance either way.

Ashraf Amayreh’s picture

Ashraf Amayreh commented

Replace the function aggregation_item_view with this one

function aggregation_item_view(&$node, $teaser = FALSE, $page = FALSE)
{
	$node = node_prepare($node, $teaser);
	if (!$teaser)
	{
		if ($node->image_id > 0)
		{
			$image = node_load($node->image_id);
			$node->image = $image;

			// theme image
			$image_render = theme('aggregation_image_render', $image);
		}
		else
		{
			$node->image_nid = NULL;
			$node->image = NULL;

			$image_render = '';
		}

		// theme body
		$body_render = theme('aggregation_body_render', $node->body);

		// theme the final item
		$node->content['body']['#value'] = theme('aggregation_item_render', $image_render, $body_render);
	}

	return $node;
}

I've tested it, but let me know how it works out for you.

I'll see if I can setup a donation system soon. Thanks for your kind offer.

JamoSmith’s picture

JamoSmith commented

This new code introduces a new issue. While fixing the problem it prevents Feed Item Body's from containing rich HTML, since this HTML will be filtered by the default Input Type (Filtered HTML). I am probably a minority to want to keep unfiltered HTML from the RSS feed, and I can always revert the aggregation_item_view function back to the old one. But, the solution to this issue would be to allow the Feed to define a default input type for the imported content.