List descendant comments on delete confirm page

I didn't check the patch yet :( No time.

But a big +1 from me. Also note, that with FLAT comments, we currently have hidden descendants: Also deleted along, but otherwise rather random and completely impossible to see anywhere (except perhaps PhpMyAdmin). There's other issue on that elsewhere (dealing with entirely other bit of that workflow), but for now it makes this fix even more important.

Patch works fine, and is a massive, massive, usability improvement for the reasons JirkaRybka outlines above.

The page description should read:

"The following replies" not "Following replies", and only single quotes required.

Also ideally the patch should be rolled from the root of your drupal directory, with the -p option, and without windows line breaks.

Otherwise code style and everything looks fine to my not very picky eyes. Marking as needs work, but these are minor gripes, and it's lovely.

Moving to Drupal 7.

I know we're late in the cycle but I'd agree with dami here. It's quite scary not knowing how many children you're going to kill when you push that button. And as JirkaRybka points out, there's no way to even go back and find out if you use "flat" comment settings. I've been using the 'nasty hack'[sic, Heine] flatcomment module for precisely this reason.

I guess there could be a performance concern if a comment had dozens of children, but then presumably that applies to the actual deletion process as well.

I'm going to drop this back down to D6 for one last chance, although I understand the reasons for postponing it at this stage. Also marking as a bug report since it's unpredictable deletion of users' data ;)

Back to D7 :)

Just tested this patch, the code still applies to Drupal 6 HEAD. It applied cleanly, and the feature is quite nice!

+1 from me.

Still applies and the functionality is great. I'm marking this RTBC since birdmanx35 also reviewed positively.

See also JirkaRybka's comments on: http://drupal.org/node/175841#comment-605205 in regard to comment deletion.

Code should use l() instead of constructing its own URL. I'm not sure I'm willing to classify this as a big usability improvement -- it adds clutter to me.

It's not a big win if you have comments set up to be threaded - because then you can work out visually what's going to go beforehand. However if you use the flat setting, you have no way of knowing which comments are replies to which (and users don't care most of the time) - which leads to very unpredictable data loss.

If no-one gets to it I'll work on a re-roll with l() soonish.

Moving.

Re-rolled as requested.

Trying again...

Patch.

One more time...

#19: comments-list_descendents_on_delete_confirm-193409-19.patch queued for re-testing.

#19: comments-list_descendents_on_delete_confirm-193409-19.patch queued for re-testing.

#19: comments-list_descendents_on_delete_confirm-193409-19.patch queued for re-testing.

Nice UX feature.
There could be a lot of descendant comments so we need to decide how to display them properly

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Since there's been no follow up on this one, going to close out. If still a valid feature though please re-open.

Thanks all!