As the work done on the WYSIWYG module, it would be nice to support CKEditor module too.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | picture-ckeditor-module-1934106-4.patch | 19.24 KB | shaundychko |
| #2 | picture-1934106-2.patch | 1.65 KB | shaundychko |
As the work done on the WYSIWYG module, it would be nice to support CKEditor module too.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | picture-ckeditor-module-1934106-4.patch | 19.24 KB | shaundychko |
| #2 | picture-1934106-2.patch | 1.65 KB | shaundychko |
Comments
Comment #1
attiks commentedI'll welcome all patches ;-)
Comment #2
shaundychkoWell, this hopefully takes things in the right direction. The really strange thing is that I can't invoke the CKEditor module's hook_ckeditor_pluging(). I've enabled/disabled the picture module, cleared the 'all' cache dozens of times... This patch shouldn't be applied, but I hope it's helpful.
This patch has the code that should work (if the hook_ckeditor_plugin() could be invoked), but has it commented out, with a couple of debug statements to check if the hook gets invoked (which it never does??)
Comment #3
attiks commentedrelated:
#1292406-11: hook_ckeditor_plugin
http://api.drupalize.me/api/drupal/function/hook_ckeditor_plugin/7 says this is used to define new plugins, so probably this will not work
Comment #4
shaundychkoThis changes how the CKEditor plugin is added to the WYSIWYG, and it now supports both the CKEditor module, and the WYSIWYG module.
Comment #5
shaundychkoComment #6
flocondetoileTested on both modules WYSIWYG and CKEditor Module (width CKEditor 4.0.1.1 library)
it works fine.
Very very great work. Awesome.
Comment #7
attiks commentedCommitted to head, thanks
Comment #8
jdanthinne commentedI've some troubles using it with
CKEditor 7.x-1.12
CKEditor lib 4.0.2
Picture 7.x-1.1+34-dev
I'm getting a js error :
TypeError: 'undefined' is not an object (evaluating 'Drupal.settings.picture.label')Comment #9
attiks commentedWhat is inside Drupal.settings.picture?
Does picture work on a regular image field
Comment #10
jdanthinne commentedDrupal.settings is undefined as well… but working on a regular image field.
Comment #11
attiks commented#10 That cannot be a good sign, do you get javascript errors on the page?
Comment #12
jdanthinne commentedNo javascript error until I click on the Image button in the CKEditor toolbar… then comes the js error.
Comment #13
attiks commentedThe strange thing is that Drupal.settings isn't defined, it should be defined in the HEAD of your document, can you see if you have something like
jQuery.extend(Drupal.settings ...in the HTMLComment #14
jdanthinne commentedOops, I wanted to say Drupal.settings.picture is undefined, not Drupal.settings, which is defined.
Comment #15
attiks commentedDid you assign the groups on admin/config/media/picture/ckeditor?
Comment #16
jdanthinne commentedMmm… didn't see these settings. I've assigned some groups and it's working fine now.
There should an error message in case of no group is assigned, don't you think?
Comment #17
attiks commentedMarking as bug, to handle the error message, if anybody can provide a patch, that would be great.
We also need to adapt the documentation.
Comment #18
attiks commentedIf somebody can provide a patch, feel free to re-open
Comment #21
rooby commentedAs far as I can tell the "Won't fix" status is not accurate and is confusing so marking as fixed.
The error message mentioned at the end should be a new issue if it is still outstanding.