As the work done on the WYSIWYG module, it would be nice to support CKEditor module too.

Comments

attiks’s picture

I'll welcome all patches ;-)

shaundychko’s picture

StatusFileSize
new1.65 KB

Well, this hopefully takes things in the right direction. The really strange thing is that I can't invoke the CKEditor module's hook_ckeditor_pluging(). I've enabled/disabled the picture module, cleared the 'all' cache dozens of times... This patch shouldn't be applied, but I hope it's helpful.

This patch has the code that should work (if the hook_ckeditor_plugin() could be invoked), but has it commented out, with a couple of debug statements to check if the hook gets invoked (which it never does??)

attiks’s picture

related:
#1292406-11: hook_ckeditor_plugin
http://api.drupalize.me/api/drupal/function/hook_ckeditor_plugin/7 says this is used to define new plugins, so probably this will not work

shaundychko’s picture

StatusFileSize
new19.24 KB

This changes how the CKEditor plugin is added to the WYSIWYG, and it now supports both the CKEditor module, and the WYSIWYG module.

shaundychko’s picture

Status: Active » Needs review
flocondetoile’s picture

Tested on both modules WYSIWYG and CKEditor Module (width CKEditor 4.0.1.1 library)
it works fine.
Very very great work. Awesome.

attiks’s picture

Status: Needs review » Fixed

Committed to head, thanks

jdanthinne’s picture

Status: Fixed » Active

I've some troubles using it with
CKEditor 7.x-1.12
CKEditor lib 4.0.2
Picture 7.x-1.1+34-dev

I'm getting a js error : TypeError: 'undefined' is not an object (evaluating 'Drupal.settings.picture.label')

attiks’s picture

What is inside Drupal.settings.picture?
Does picture work on a regular image field

jdanthinne’s picture

Drupal.settings is undefined as well… but working on a regular image field.

attiks’s picture

#10 That cannot be a good sign, do you get javascript errors on the page?

jdanthinne’s picture

No javascript error until I click on the Image button in the CKEditor toolbar… then comes the js error.

attiks’s picture

The strange thing is that Drupal.settings isn't defined, it should be defined in the HEAD of your document, can you see if you have something like jQuery.extend(Drupal.settings ... in the HTML

jdanthinne’s picture

Oops, I wanted to say Drupal.settings.picture is undefined, not Drupal.settings, which is defined.

attiks’s picture

Did you assign the groups on admin/config/media/picture/ckeditor?

jdanthinne’s picture

Mmm… didn't see these settings. I've assigned some groups and it's working fine now.
There should an error message in case of no group is assigned, don't you think?

attiks’s picture

Category: feature » bug

Marking as bug, to handle the error message, if anybody can provide a patch, that would be great.

We also need to adapt the documentation.

attiks’s picture

Issue summary: View changes
Status: Active » Closed (won't fix)

If somebody can provide a patch, feel free to re-open

  • Commit c859056 on 7.x-1.x, picturefill2 authored by ShaunDychko, committed by attiks:
    Issue #1934106 by Shaun Dychko | flocondetoile: Added CKEditor module...
  • Commit 1471487 on 7.x-1.x, picturefill2 authored by ShaunDychko, committed by attiks:
    Issue #1934106 by Shaun Dychko | flocondetoile: Added CKEditor module...

  • Commit c859056 on 7.x-1.x, picturefill2, 7.x-2.x authored by ShaunDychko, committed by attiks:
    Issue #1934106 by Shaun Dychko | flocondetoile: Added CKEditor module...
  • Commit 1471487 on 7.x-1.x, picturefill2, 7.x-2.x authored by ShaunDychko, committed by attiks:
    Issue #1934106 by Shaun Dychko | flocondetoile: Added CKEditor module...
rooby’s picture

Status: Closed (won't fix) » Fixed

As far as I can tell the "Won't fix" status is not accurate and is confusing so marking as fixed.

The error message mentioned at the end should be a new issue if it is still outstanding.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.