Bulk operation for reverting meta tags [#1934492]

Comment	File	Size	Author
#11	metatag-n1934492-11.patch	6.16 KB	damienmckenna
#6	metatag-revert_default-1934492-6.patch	6.4 KB	juampynr
#6	Selection_001.png	34.59 KB	juampynr
#3	metatag-revert_default-1934492-3.patch	5.05 KB	juampynr
#3	Selection_001.png	20.85 KB	juampynr
	Selection_002.png	13.9 KB	juampynr

Comment #1

damienmckenna

TN, USA

commented 5 March 2013 at 21:28

(misread, never mind)

Log in or register to post comments

Comment #2

damienmckenna

TN, USA

commented 5 March 2013 at 21:28

This action would basically just remove the meta tag records for the selected entities, right?

Log in or register to post comments

Comment #3

juampynr commented 6 March 2013 at 19:00

Status:

Active

» Needs review

Status	File	Size
new	Selection_001.png	20.85 KB
new	metatag-revert_default-1934492-3.patch	5.05 KB

Here is a patch that adds a "Bulk revert" tab that shows a form like the following image. For simplicity I started by just supporting nodes, letting the user choose on content types, but this could be extended afterwards to all entities that support metatags.

Log in or register to post comments

Comment #4

damienmckenna

TN, USA

commented 6 March 2013 at 19:23

Status:

Needs review

» Needs work

Thanks for working on this. Am pushing it back to Needs Work with the following suggestions:

It really needs more on-screen help to explain what's going on, you don't want people saying "but I thought that would just change the defaults" after they've wiped out their data.
Given that Metatag works for more than just nodes, a better way of handling it might be to add a per-entity option to revert meta tags for all matching objects matching that entity type with an extra option that checks for the list of bundles the entity has.

Log in or register to post comments

Comment #5

juampynr commented 6 March 2013 at 19:39

@DamienMcKenna, thanks for the quick feedback. I will give another stab at this later. I have some code I got rid of at the end for handling all entity/bundles that support metatags.

Log in or register to post comments

Comment #6

juampynr commented 7 March 2013 at 03:43

Status:

Needs work

» Needs review

Status	File	Size
new	Selection_001.png	34.59 KB
new	metatag-revert_default-1934492-6.patch	6.4 KB

Here it is:

* Added hook_help() to be extra verbose on what this task do.
* Now it supports all entity/bundles. However, I had to add a dirty condition so it could revert users. This is related with a pending Drupal 7 bug which is being discussed at #1054168: EntityFieldQuery fails for entities that have no bundle and, although it does not show an error, it returns 0 users if -->entityCondition('bundle', 'user') is set.

Log in or register to post comments

Comment #7

damienmckenna

TN, USA

commented 7 March 2013 at 04:36

@juampy: Very nice! I'll give it a more thorough review tomorrow, but this looks great!

Log in or register to post comments

Comment #8

damienmckenna

TN, USA

commented 12 March 2013 at 03:31

Status:

Needs review

» Needs work

I think this needs one other improvement: an option to select the specific meta tags to be erased. My idea is that it would add a new (required, no default) selector to change between "all meta tags" and "specific meta tags", if the latter option is selected it would show a set of checkboxes to choose the meta tags that are removed. This would also help resolve #1939396: MetaTag doesn't return the default value when field is empty.