I found a quirky bug. It either lives in the diff.module (march or november download) or drupal 5.3. I suspect drupal 5.3, although the problem only occurs with the diff.module from what I have seen. Here's the problem. When using the diff.module on 5.3 and you click the diff button to compare two versions of a document, something inserts empty menu items into the main navigation menu. Drupal.org itself has this very problem...go to http://drupal.org/node/20492/revisions/view/121158/124284 (after logging in) and and look below 'My projects'...two empty menu items. Man...that's annoying. This does not happen on drupal 5.2 and it is not theme specific...I've tried 5 different themes. Any ideas on what this is and how to fix it?

cheers,

wim

Comments

mfer’s picture

mfer commented

The two added bullets with no text look to be the delete and revert links.

battochir’s picture

battochir commented

Thanks for pointing that out. I saw that in the source code of the rendered page. The links themselves are incomplete as no actual links are given. Any idea why this is? I'm thinking of just using css to hide the bullets and links, but that's kludgy. I can't seem to isolate the offending code from the code necessary to render the page without creating a bigger mess. Any idea on how to get rid of it otherwise?

thanks,

wim

battochir’s picture

battochir commented

Thanks for pointing that out. I saw that in the source code of the rendered page. The links are incomplete as no actual links are given...just bullets and empty link spaces. Any idea what's causing it? I thought about just using css to hide the bullets and the links, but that's kludgy. I can't seem to isolate the offending code without making a bigger mess. Any ideas on how to otherwise get rid of this mess? Why does this not happen in 5.2?

thanks,

wim

battochir’s picture

battochir commented

Ok. I've gone through the diff_menu(). My problem is that the menu path 'node/$nid/revisions' is overriden with 'diff_diffs' and I don't know where these two menu items are actually coming from or what's generating them. The links themselves are incomplete as no actual links are given. Just two bullets and two empty link spaces. Can someone please tell me where these menu items are coming
from and what's generating them?

thanks,

wim

damien tournoud’s picture

damien tournoud commented

The problem lies in Drupal Core changes for patching DRUPAL-SA-2007-017.
Corrected in D6 (during the menu system refactoring), but still not in the DRUPAL-5 branch. Already identified in bug #166034, but without any patch proposal for now.

damien tournoud’s picture

damien tournoud commented
Title: drupal 5.3 or diff.module bug? » Phantom menu items during Diff on Drupal 5.x
dww’s picture

dww
we/he/they
commented
Status: Active » Closed (duplicate)

Yup, seems like it's really just the bug in http://drupal.org/node/166034. No sense keeping this active in the diff queue, since there's nothing we can do to fix it here.