Right now, retweets show the retweeted user, making it appear as though I had selected that user to show their tweets. There should be an option for what the behavior should be. Attaching a dead simple patch that also fixes the issue at http://drupal.org/node/1933110 since it's the same line of code. Just adds a variable, "twitter_pull_retweet_user", that is checked before assigning the retweet user as the one to use. Defaults to TRUE so that things don't change on people. No admin interface for setting this variable.

CommentFileSizeAuthor
#10 twitter_pull-retweet-user-1935318-5.patch816 bytescdenneen
#9 twitter_pull-retweet-user-1935318-4.patch798 bytescdenneen
#7 twitter_pull-retweet-user-1935318-7.patch892 byteselliotttf
#3 twitter_pull-retweet-user-1935318-3.patch830 byteswbobeirne
#2 twitter_pull-retweet-user-1935318-2.patch686 byteswbobeirne
#1 twitter_pull-retweet-user-1935318-1.patch784 byteswbobeirne

Comments

wbobeirne’s picture

wbobeirne commented
Status: Active » Needs review
StatusFileSize
new twitter_pull-retweet-user-1935318-1.patch784 bytes
wbobeirne’s picture

wbobeirne commented
StatusFileSize
new twitter_pull-retweet-user-1935318-2.patch686 bytes

Apologies, left a comment of the original implementation in there. Attaching a new patch without that comment.

wbobeirne’s picture

wbobeirne commented
StatusFileSize
new twitter_pull-retweet-user-1935318-3.patch830 bytes

So it turns out twitter_pull sends in the item as an array with nested arrays, and the twitter module sends it in as an object with nested objects. Simply casting wasn't working because that's not recursive, so I'm attaching a patch that does a json encode/decode to get the whole thing to be an object.

victoriachan’s picture

victoriachan commented

I've tested this. It works well and fixes the bug caused by $item array/object inconsistency as well (#1933110).

Hope it gets committed.

Thanks!

tinkerbelle’s picture

tinkerbelle commented

Another vote for this patch working, fixing #1933110: Incorrect parsing of items. (notices ar thrown), and being something I'd love to see committed!
Thanks wbobeirne!

mfernea’s picture

mfernea commented
Status: Reviewed & tested by the community » Needs review

I agree that the patch at #3 solves #1933110: Incorrect parsing of items. (notices ar thrown) too.

elliotttf’s picture

elliotttf commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new twitter_pull-retweet-user-1935318-7.patch892 bytes

I had to convert the user to an object for my use case too, but otherwise this worked perfectly.

wbobeirne’s picture

wbobeirne commented
Status: Needs review » Reviewed & tested by the community

#7, json_encode / json_decode recursively converts an array to an object. No need to do it twice.

cdenneen’s picture

cdenneen commented
StatusFileSize
new twitter_pull-retweet-user-1935318-4.patch798 bytes

@wbobeirne

I've created patch #4 which is the same as your patch #3 but applies cleanly with http://drupal.org/files/typecast_user_variable_in_twitter_class-1781024-...
that contains a patch to fix the lists author issue with 7.x-2.x-dev (http://drupal.org/node/1781024#comment-7232862)

cdenneen’s picture

cdenneen commented
StatusFileSize
new twitter_pull-retweet-user-1935318-5.patch816 bytes

@wbobeirne

For some reason the git diff got truncated here is the #5 patch which should fix the issue with #4

jec006’s picture

jec006 commented
Status: Reviewed & tested by the community » Fixed

Thanks guys, committed here: http://drupalcode.org/project/twitter_pull.git/commit/86d7532

Thanks to all of you

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

joachim’s picture

joachim commented

> No admin interface for setting this variable.

And no documentation either! How is anyone meant to know this exists?

joachim’s picture

joachim commented
Issue summary: View changes

Added link to issue