Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
rest.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
6 Mar 2013 at 20:32 UTC
Updated:
29 Jul 2014 at 21:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Anonymous (not verified) commentedThis patch depends on #1924220: Support serialization in hal+json and #1931976: Support deserialization for hal+json (needs more language handling tests).
It also required a few small changes in the REST module. Specifically, on PATCH it ensures that the id and uuid properties from the new entity do not overwrite those of the original.
Comment #2
Anonymous (not verified) commentedReroll since info.yml got in.
Comment #3
klausiwhy is the UUID protected from writing? I can see that most use cases will never do that, but why artificially restricting it?
Otherwise this looks good!
Comment #4
Crell commentedIf we can't rely on uuid not changing, we can't build any functionality based off of uuid being, er, universally unique. If you want an object to have a different uuid... make a new object. (If we allow it, someone somewhere is going to change it and then we'll never be able to rely on the uuid again.)
Comment #5
Anonymous (not verified) commentedReroll due to changes made in the REST test and HAL serialization getting in.
The .patch file includes the latest patch from #1931976: Support deserialization for hal+json (needs more language handling tests).
Comment #6
Crell commentedThe for-review patch is dead simple and seems fine. If anything, I'd ask if we should be centralizing our definition of default so that we don't have to restate it in 50 places.
The dependent issue is still CNW, though, so we can't RTBC this one.
Comment #7
webchick#5: 1935538-05-rest-test-update.patch queued for re-testing.
Comment #9
xjmProbably just need to upload the
.txtfile in #5 with a.patchextension.Comment #11
xjmxpost.
Comment #12
Anonymous (not verified) commentedChanges in the REST tests since I posted this, have to reroll.
Comment #13
Anonymous (not verified) commentedHere's a partial reroll, it still fails one of the tests. I won't have a chance to come back to it until this evening.
Comment #15
Anonymous (not verified) commentedI think I might need Klaus to take a look at these fails. I don't see a clear reason why in these three instances, switching to HAL would give a 500 instead of a 403, but it might be more obvious to him.
Comment #16
Anonymous (not verified) commentedThe last patch reverted one of eff's fixes from the deserialization patch, so this just reintroduces that change. It doesn't fix the test fails, eff said he would take a look.
Comment #17
effulgentsia commentedJust a silly typo fix.
Comment #18
effulgentsia commentedThis just removes hunks unrelated to this issue. I moved them into #1931976-28: Support deserialization for hal+json (needs more language handling tests). I'll follow up with one more reroll for #6.
Comment #19
effulgentsia commentedAgreed. Done here. This changes nearly every line so no point in an interdiff.
Comment #20
moshe weitzman commentedThanks for fixing tests
Comment #21
webchickOh, JSON-LD. We blow a trumpet for thee. Do we need another patch to remove the module as a whole?
In the meantime, this looks like it cleans up an awful lot of hard-coding as well as switching to a more recognized(?) format, so woohoo.
Committed and pushed to 8.x. Thanks!
Comment #22
webchickActually. I imagine this will require a change to a change notice somewhere, else a new one to be made if it doesn't already exist.
Comment #23
Anonymous (not verified) commentedShouldn't the change notice be for #1935548: Remove JSON-LD module?
Comment #24
effulgentsia commentedMoved the change notice requirement to #1816354-43: Add a REST module, starting with DELETE.