Hi, a few months back I submitted a patch that added support for Modernizr module API in #1735496: Geolocation Field: Integration with Modernizr 7.x-3.x. I was doing some testing today and realized I gave you a patch for the wrong module. Right now, if the base geolocation module is enabled, it requests Geolocation API test from Modernizr. It really needs to live inside geolocation_html5 module, since that's the module relying on the new web standard. My mistake!

CommentFileSizeAuthor
#2 1935794-2-modernizr-geolocation-html5.patch1.15 KBrupl
#1 1935794-1-modernizr-geolocation-html5.patch1.2 KBrupl

Comments

rupl’s picture

rupl
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 1935794-1-modernizr-geolocation-html5.patch1.2 KB

In the mean time, I've simplified how modules implement the hook, so as a small bonus the patch removes more code than it adds.

rupl’s picture

rupl
he/him
Primary language English
commented
Assigned: rupl » Unassigned
StatusFileSize
new 1935794-2-modernizr-geolocation-html5.patch1.15 KB

Re-rolling to further simplify hook implementation.

derjochenmeyer’s picture

derjochenmeyer commented
Status: Needs review » Fixed

Looks good => committed

rupl’s picture

rupl
he/him
Primary language English
commented

Somehow I missed the email notification but thanks for committing this!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.