Curiously enough, temporary was never checked in core. LOCK was. temporary was mentioned in a TXT. It gives me big please to submit this patch. Props to David Strauss for patching out some locks and explaining how an UPDATE-INSERT is enough. Props to Doug Green for streamling search. The rest (db_next_id, block admin) I dealt with.

CommentFileSizeAuthor
#4 CHANGELOG-dbreqs-193580_0.patch573 bytesgpk
#2 CHANGELOG-dbreqs-193580.patch574 bytesgpk
temptablelock.patch3.31 KBchx

Comments

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Active

Great, committed. IMHO this is CHANGELOG worthy information, if the existing changelog entries did not cover this yet. I also included a note about this in the beta 3 release notes document a few hours before. :) Marking this active for possible changelog mentions.

gpk’s picture

gpk commented
Status: Active » Needs review
StatusFileSize
new CHANGELOG-dbreqs-193580.patch574 bytes

Belated, but for the avoidance of confusion (http://drupal.org/node/278871).
Applies to 6.x, and 7.x with offset.

robin monks’s picture

robin monks commented

+1 on the basis of style

gpk’s picture

gpk commented
Assigned: chx » Unassigned
StatusFileSize
new CHANGELOG-dbreqs-193580_0.patch573 bytes

Slightly improved wording for the CHANGELOG.txt mention.

BartVB’s picture

BartVB commented
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community

Seems like the changelog patch is a bit late, the actual code change has been in Drupal 6 for ages now.

Patch seems to be fine though against DRUPAL-6 :)

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Version: 6.x-dev » 7.x-dev

Committed, although it was quite late indeed :) Should be committed to 7.x as well.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD as well. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.