Curiously enough, temporary was never checked in core. LOCK was. temporary was mentioned in a TXT. It gives me big please to submit this patch. Props to David Strauss for patching out some locks and explaining how an UPDATE-INSERT is enough. Props to Doug Green for streamling search. The rest (db_next_id, block admin) I dealt with.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | CHANGELOG-dbreqs-193580_0.patch | 573 bytes | gpk |
| #2 | CHANGELOG-dbreqs-193580.patch | 574 bytes | gpk |
| temptablelock.patch | 3.31 KB | chx |
Comments
Comment #1
gábor hojtsyGreat, committed. IMHO this is CHANGELOG worthy information, if the existing changelog entries did not cover this yet. I also included a note about this in the beta 3 release notes document a few hours before. :) Marking this active for possible changelog mentions.
Comment #2
gpk commentedBelated, but for the avoidance of confusion (http://drupal.org/node/278871).
Applies to 6.x, and 7.x with offset.
Comment #3
robin monks commented+1 on the basis of style
Comment #4
gpk commentedSlightly improved wording for the CHANGELOG.txt mention.
Comment #5
BartVB commentedSeems like the changelog patch is a bit late, the actual code change has been in Drupal 6 for ages now.
Patch seems to be fine though against DRUPAL-6 :)
Comment #6
gábor hojtsyCommitted, although it was quite late indeed :) Should be committed to 7.x as well.
Comment #7
dries commentedCommitted to CVS HEAD as well. Thanks.