Posted by msonnabaum on March 7, 2013 at 5:35am
5 followers
| Project: | Drupal core |
| Version: | 8.x-dev |
| Component: | base system |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | reviewed & tested by the community |
| Issue tags: | phpunit |
Issue Summary
Here's an easy one to start.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| graph-phpunit.patch | 4.25 KB | Idle | PASSED: [[SimpleTest]]: [MySQL] 52,414 pass(es). | View details | Re-test |
Comments
#1
I feel its awesome we have phpunit tests in core!
+++ b/core/tests/Drupal/Tests/Component/Graph/GraphUnitTest.php@@ -2,20 +2,20 @@
public static function getInfo() {
return array(
the getInfo function is not relevant in phpunit tests anymore?
+++ b/core/tests/Drupal/Tests/Component/Graph/GraphUnitTest.php@@ -2,20 +2,20 @@
/**
* Unit tests for the graph handling features.
*
* @see Drupal\Component\Graph\Graph
*/
-class GraphUnitTest extends UnitTestBase {
add one or more @group annotations here. I am thinking of somthing like:
* @group Component* @group Graph
#2
@msonnabaum: Why is the unit test moved? Is there some documentation about this?
See also #1938068: [Meta] Convert UnitTestBase to PHPUnit
#3
Tagging
Besides
+++ b/core/tests/Drupal/Tests/Component/Graph/GraphUnitTest.phpundefined@@ -2,20 +2,20 @@
+ * Definition of Drupal\Tests\Component\Graph\GraphUnitTest.
Should be
Contains \Drupal\Tests...this seems ready
#4
#5
The last submitted patch, drupal-graph_phpunit-1935908-4.patch, failed testing.
#6
#4: drupal-graph_phpunit-1935908-4.patch queued for re-testing.
#7
The last submitted patch, drupal-graph_phpunit-1935908-4.patch, failed testing.
#8
/me facepalms
#9
@ParisLiakos for future references: do you have some documentation to add in #1938068: [Meta] Convert UnitTestBase to PHPUnit as most people will be puzzled how to create a patch for a git mv, replace t() by sprintf, etc ... btw: I should have documented that myself :-/
+++ b/core/tests/Drupal/Tests/Component/Graph/GraphTest.php@@ -2,20 +2,22 @@
public static function getInfo() {
return array(
Shouldn't this be removed as mentioned by @franskuipers in #1?
And what about his
@group Component#10
No, we still need it for Simpletest UI ;)
And there is no Component group, so far groups refer to a module, but definitely we should come up with a standard
#11
Then the patch looks ok to me :)