This one required changing the path it uses to a temporary path. Even if that's not 100% right, we should figure that out because its the only thing preventing it form working outside a drupal install.

CommentFileSizeAuthor
phpfilestorage-phpunit.patch9.7 KBmsonnabaum

Comments

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

That's good.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +PHPUnit

Cool, this isn't that bad, which is nice.

From reading this, I filed two follow-up issues: #1945048: Move all tests to a Drupal\Tests\* namespace? and #1945040: Rename assertIdentical() to assertSame() for better compatibility with PHPUnit — to try and bring our overall test suite more inline with PHPUnit.

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

sylvain lecoy’s picture

sylvain lecoy commented

Its fixed but you could use a vfsStreamWrapper, as demoed in #1872006-5: Add parity test classes for lib/Core and lib/Component.