Download & Extend

Convert PhpStorage tests to phpunit

Project:Drupal core
Version:8.x-dev
Component:base system
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:phpunit

Issue Summary

This one required changing the path it uses to a temporary path. Even if that's not 100% right, we should figure that out because its the only thing preventing it form working outside a drupal install.

AttachmentSizeStatusTest resultOperations
phpfilestorage-phpunit.patch9.7 KBIdlePASSED: [[SimpleTest]]: [MySQL] 52,393 pass(es).View details

Comments

#1

Status:needs review» reviewed & tested by the community

That's good.

#2

Status:reviewed & tested by the community» fixed

Cool, this isn't that bad, which is nice.

From reading this, I filed two follow-up issues: #1945048: Move all tests to a Drupal\Tests\* namespace? and #1945040: Rename assertIdentical() to assertSame() for better compatibility with PHPUnit — to try and bring our overall test suite more inline with PHPUnit.

Committed and pushed to 8.x. Thanks!

#3

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#4

Its fixed but you could use a vfsStreamWrapper, as demoed in #1872006-5: [PHPUnit] Add parity test classes for lib/Core and lib/Component.

nobody click here