Posted by Wim Leers on March 7, 2013 at 11:10am
9 followers
Jump to:
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | image.module |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Wim Leers |
| Status: | needs work |
Issue Summary
The Drupal 7.20 security release introduced this change:
- return file_create_url($uri);
+ $file_url = file_create_url($uri);
+ // Append the query string with the token.
+ return $file_url . (strpos($file_url, '?') !== FALSE ? '&' : '?') . drupal_http_build_query($token_query);This means the query string is effectively not available for hook_file_url_alter() to be modified, i.e. it breaks file URL altering.
This breaks CDN module's Far Future expiration functionality.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| 7.21_correct_file_create_url_usage.patch | 776 bytes | Idle | FAILED: [[SimpleTest]]: [MySQL] 40,405 pass(es), 30 fail(s), and 4 exception(s). | View details | Re-test |
Comments
#1
The last submitted patch, 7.21_correct_file_create_url_usage.patch, failed testing.
#2
#3
7.21_correct_file_create_url_usage.patch queued for re-testing.
#4
The last submitted patch, 7.21_correct_file_create_url_usage.patch, failed testing.