Some of my private chat messages were displaying in public chat room! It is strange!

EDIT:
It is 'Normal Ajax' method.
Steps to reproduce:

  1. Speed up the Input: i.e , Type the new chat text to 'public chat' immediately after enter chat text to private chat.

I think it is because the JS script collects all the inputs and send to server with the 'last input window' details.

see the attached screen shot.

CommentFileSizeAuthor
#6 Screenshot from 2013-11-09 19:27:21.png60.06 KBvinoth.3v

Comments

darklrd’s picture

darklrd commented

Which polling method are you using? Thanks.

vinoth.3v’s picture

vinoth.3v commented

normal ajax

vinoth.3v’s picture

vinoth.3v commented

any update?

darklrd’s picture

darklrd commented
Status: Active » Closed (cannot reproduce)

I am unable to re-create this issue. Please provide some more details which would help in creating this issue. Also, a screenshot would be very helpful. Please re-open this once you provide further information. Thanks.

vinoth.3v’s picture

vinoth.3v commented

It happens very rarely, I am not sure at which situation this happens. but I am sure it happened some times on my live site.

vinoth.3v’s picture

vinoth.3v commented
Issue summary: View changes
Status: Closed (cannot reproduce) » Active
StatusFileSize
new Screenshot from 2013-11-09 19:27:21.png60.06 KB

I can reproduce this security/privacy bug in latest dev.

It is 'Normal Ajax' method.
Steps to reproduce:

  1. Speed up the Input: i.e , Type the new chat text to 'public chat' immediately after enter chat text to private chat.

I think it is because the JS script collects all the inputs and send to server with the 'last input window' details.

vinoth.3v’s picture

vinoth.3v commented
Issue summary: View changes
darklrd’s picture

darklrd commented

Thank you for providing steps and screenshots. I will check it out now. Your theory does seem to be correct.

vinoth.3v’s picture

vinoth.3v commented

Thank you,
And you can increase the heartbeat delay so testing would be easy I think.

vinoth.3v’s picture

vinoth.3v commented

Any update?

darklrd’s picture

darklrd commented
Status: Active » Fixed

This happens while using AJAX polling method due to introducing delay while sending messages. I have removed this delay now. Committed - http://drupalcode.org/project/drupalchat.git/commit/c09d73f. Thanks!

vinoth.3v’s picture

vinoth.3v commented

Good

  • Commit c09d73f on 7.x-1.x by darklrd: 
    Issue #1936998 by darklrd: Private messages are displayed in public chat...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.