When editing (or creating new) configuration, and adding two new steps of the same type, the pre-filled machine name of the second step is set to the same value as the first step. When saving the configuration, a PDO error is thrown saying that the step name already exists in the database.

CommentFileSizeAuthor
#1 media_mover_core_unique_machine_name-1937026-1.patch4.34 KBiva2k

Comments

iva2k’s picture

iva2k commented
Status: Active » Needs review
StatusFileSize
new media_mover_core_unique_machine_name-1937026-1.patch4.34 KB

Here's a patch that fixes this problem. The trick is to save all ids that were issued by media_mover_api_machine_name_create() in cache for future reference.

Status: Needs review » Needs work

The last submitted patch, media_mover_core_unique_machine_name-1937026-1.patch, failed testing.

iva2k’s picture

iva2k commented

My sandbox is way ahead of the 7.x-1.x-dev and I lost track of which patches that I submitted are still not committed.

How can we get old issues with "needs review" moving forward?

arthurf’s picture

arthurf commented
Status: Needs work » Closed (fixed)

I patched this by hand as this simply wasn't going to apply.