Closed (duplicate)
Project:
Drupal core
Version:
8.0.x-dev
Component:
configuration system
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
8 Mar 2013 at 10:04 UTC
Updated:
29 Jul 2014 at 21:59 UTC
Jump to comment: Most recent file
Comments
Comment #1
ACF commentedComment #2
aspilicious commentedI would split this in 2 lines.
Comment #3
ACF commentedComment #4
berdirAnd this looks good as well.
Comment #5
dries commentedCommitted to 8.x. Thanks!
Comment #6
sunSorry, but this was not correct.
The image JPEG quality setting belongs to the Image Toolkit API. The Image Toolkit API does not belong to Image module and can be used without that module being installed.
We do not seem to have any config settings for image toolkits yet. The setting should be moved into a system.image.yml config file.
Comment #7
berdirUh, sorry, my fault. I guess we can't really add useful test coverage here (explicitly checking the default values of all configuration is kinda pointless and it's hard to verify that a jpg was created with the correct quality I guess ;)).
#1664844: Convert image toolkits into plugins introduces "config('system.image')->get('toolkit')", I guess we could move it into the same system.image config file. Not worried about a conflict with that other issue, that already doesn't apply anymore anyway.
Comment #8
aspilicious commentedOk I'm going to close this and crossreference the other issue.
Comment #9
sunThe proper status would be fixed, but I disagree with merging the two issues.
We should either revert the committed patch or quickly fix it up. I'd prefer the latter.
Comment #10
berdirI checked it and it seems to be complicated to fix as it's part of the plugin settings and is currently actually broken because the value is never saved. So here's a revert patch, I assume the other issue will take care of converting it propertly.
Comment #11
sunI did not fully understand the reason, but rolling it back works for me, too.
Comment #12
webchickOK, rolled back. I guess then this becomes a duplicate on #1664844: Convert image toolkits into plugins?