subissue of #1775842: [meta] Convert all variables to state and/or config systems.

CommentFileSizeAuthor
#2 1937196-cmi-image_toolkit-drupal-2.patch2.76 KBACF
#1 1937196-cmi-image_toolkit-drupal-1.patch2.53 KBACF

Comments

ACF’s picture

ACF commented
Status: Active » Needs review
StatusFileSize
new 1937196-cmi-image_toolkit-drupal-1.patch2.53 KB

Slightly torn about whether the configuration should be called 'toolkit' or 'current_toolkit', went for just 'toolkit' in the end.

ACF’s picture

ACF commented
StatusFileSize
new 1937196-cmi-image_toolkit-drupal-2.patch2.76 KB

Oops forgot the yml file.

aspilicious’s picture

aspilicious commented

I wonder if it needs a seperate yml file or if it just needs to be added to the system settings one. I'm not sure.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

I think this is happening as part of #1664844: Convert image toolkits into plugins

ACF’s picture

ACF commented
Status: Needs review » Closed (duplicate)

Yep seems this is a duplicated effort.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Re-rolled the other patch, closing this as a duplicate.