Subissue of #1775842: [meta] Convert all variables to state and/or config systems.

CommentFileSizeAuthor
#3 1937212-state-node_test_vars-drupal-3.patch2.97 KBACF
#1 1937212-state-node_test_vars-drupal-1.patch2.95 KBACF

Comments

ACF’s picture

ACF commented
Status: Active » Needs review
StatusFileSize
new 1937212-state-node_test_vars-drupal-1.patch2.95 KB
aspilicious’s picture

aspilicious commented 
+++ b/core/modules/node/tests/modules/node_test/node_test.moduleundefined
@@ -160,7 +160,7 @@ function node_test_node_update(Node $node) {
+  if ($change_view_mode = state()->get( 'node_test_change_view_mode') ?: '') {

Can we split this in 2 lines? A bit more readable.

ACF’s picture

ACF commented
StatusFileSize
new 1937212-state-node_test_vars-drupal-3.patch2.97 KB
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Looks good.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +SprintWeekend2013

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.