Very nice to see that the Location information can now be provided within the feed items!

Currently the module can only pull the Location from Text and Node Reference fields. As many use cases will implement an Addressfield within a node, it would be nice to be able to use it for the Location information of the iCal feed items.

Markus

CommentFileSizeAuthor
#6 date_ical-addressfield-support-1937224-6.patch1.79 KBvlad.pavlovic
#4 date_ical-addressfield-support-1937224-4.patch1.79 KBvlad.pavlovic

Comments

coredumperror’s picture

coredumperror commented

Hmmm, I'm not experienced with this kind of thing, but adding even more code to support even more contrib modules seems like it might not be the appropriate method. I could be totally wrong, though. Does anyone have experience with integrating several contrib modules' features together?

coredumperror’s picture

coredumperror commented

I'm an idiot. Of course Date iCal should support this. I can't promise that it'll happen soon, though.

vlad.pavlovic’s picture

vlad.pavlovic commented

Robert, would you like for me to take care of it?

vlad.pavlovic’s picture

vlad.pavlovic commented
Status: Active » Needs review
StatusFileSize
new date_ical-addressfield-support-1937224-4.patch1.79 KB

Attached is a patch that will add addressfield support. I have explicitly removed 'first_name' and 'last_name' from the Addressfield output for LOCATION.

Let me know if there are any issues and if not, I can push to dev.

coredumperror’s picture

coredumperror commented

Thanks for this, vlad. I've been on vacation for the last two weeks, so I hadn't had time to even think about this.

vlad.pavlovic’s picture

vlad.pavlovic commented
Status: Needs review » Closed (fixed)
StatusFileSize
new date_ical-addressfield-support-1937224-6.patch1.79 KB

Patch has be re-rolled to include previous fixes for other issues.

I have pushed it to dev.

vlad.pavlovic’s picture

vlad.pavlovic commented
Status: Closed (fixed) » Fixed

Meant to mark fixed, not close it.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.