subissue of #1775842: [meta] Convert all variables to state and/or config systems.

CommentFileSizeAuthor
#5 1937270-cmi-css_cache_files-drupal-5.patch1.86 KBACF
#1 1937270-cmi-css_cache_files-drupal-1.patch1.86 KBACF

Comments

ACF’s picture

ACF commented
Status: Active » Needs review
StatusFileSize
new 1937270-cmi-css_cache_files-drupal-1.patch1.86 KB
aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

thnx!

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work 
-  $map = variable_get('drupal_css_cache_files', array());
+  $map = config('system.performance')->get('cache.css_files');

Should be state like the rest no?

aspilicious’s picture

aspilicious commented

Woow yes catch. Srry missed that!

ACF’s picture

ACF commented
Status: Needs work » Needs review
StatusFileSize
new 1937270-cmi-css_cache_files-drupal-5.patch1.86 KB

Apologies, should have spotted that myself.

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

This should be good to go...

xjm’s picture

xjm
she/her
Primary language English
commented

#5: 1937270-cmi-css_cache_files-drupal-5.patch queued for re-testing.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Quick fix
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.