Download & Extend

Remove 'bundles' key from the MenuLink class annotation

Project:Drupal core
Version:8.x-dev
Component:menu_link.module
Category:task
Priority:minor
Assigned:Unassigned
Status:closed (fixed)
Issue tags:Quick fix

Issue Summary

Bundle info has been moved to a new hook hook_entity_bundle_info() and the menu_link entity type doesn't even need to explicitely declare any bundle at the moment.

Comments

#1

Status:active» needs review

And the patch.

AttachmentSizeStatusTest resultOperations
1937384.patch572 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 52,452 pass(es).View details

#2

Status:needs review» reviewed & tested by the community

#3

Status:reviewed & tested by the community» needs review

Can't get any 'quicker' fix than this :)

#4

Status:needs review» reviewed & tested by the community

Sorry, x-post.

#5

#6

Status:reviewed & tested by the community» needs work

Where is this bundle defined then? I see user defines it with this hook, but no such hook for menu items? http://api.drupal.org/api/drupal/core%21includes%21entity.api.php/functi...

#7

Status:needs work» reviewed & tested by the community

It's provided by default in entity_get_bundles().

#8

Why do user module define it then?

#9

Status:reviewed & tested by the community» needs review

Looks like this still needs discussion.

#10

I've been responded to on IRC that people don't know either. However a module doing something relatively useless should not be a reason for this to do it too. One thing that user module does is it specifies a path for the account settings (as the bundle config path?) which is kind of odd. Although if that is useful for some UI interaction, then maybe menu module should do the same?

#11

That path is used by Field UI so the 'Manage fields' and 'Manage Display' screens are placed correctly, so that's only usefull if your entity is fieldable.

#12

Status:needs review» reviewed & tested by the community

Thanks!

#13

Status:reviewed & tested by the community» fixed

Committed and pushed to 8.x. Thanks!

#14

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here