Closed (fixed)
Project:
Libraries API
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
8 Mar 2013 at 15:57 UTC
Updated:
31 Oct 2013 at 11:48 UTC
Jump to comment: Most recent file
Comments
Comment #1
polComment #2
polForgot to update the comment.
Comment #4
polFix on the patch + tests
Comment #5
polComment #6
tstoecklerLet's see what the test-bot says this time. This looks good to go!
In a follow-up we should add dedicated tests for the new callback group. Because the previous patches demonstrate that we have sufficient test coverage, and, thus, that this patch doesn't break anything, and because @Pol needs this for OpenLayers, I will commit the patch as is, instead of requiring the tests now. If now one beats me to it, I will provide some tests. (Should be mostly copy-paste.)
Comment #8
polTests still failling, I can't fix it.
Comment #10
tstoecklerHere we go. This includes test-coverage, which was (even) easier than I expected.
Comment #11
pol\o/
Comment #12
tstoecklerThanks! I'll commit this later.
In case @sun is following along at home, I plan to release a new version with this commit, because @Pol needs it for OpenLayers.
Comment #13
tstoecklerPre commit I fixed the trailing whitespace and also added an example pre-dependencies-load callback to the example library.
Committed this to 7.x-2.x
http://drupalcode.org/project/libraries.git/commit/7d2a3db42f7553dca65e6...
Comment #14
hass commented#1938638: Cached libraries (with corrupt data structure) are being loaded on update.php before the update from 2.0 to 2.1 may be introduced by this patch.
Comment #16
tstoecklerThis was never committed to 7.x-3.x
Did so now: http://drupalcode.org/project/libraries.git/commit/bc29efec5073d93bde93d...