If Toolbar module or Overlay is enabled the Navbar module does not work properly at all.

hook_install() need to disable both modules.

Both causes a lot of issues and break navbar completly.

Issues:

  • Overlay: Tabs are overlayed by menu
  • Toolbar: click on menu shows a completly destroyed navbar
CommentFileSizeAuthor
#1 navbar_Disable+colliding+modules+in+hook_install.patch589 byteshass

Comments

hass’s picture

hass commented
Issue summary: View changes

a

hass’s picture

hass commented
Title: Disabled colliding modules in hook_install() » Disable colliding modules in hook_install()
Version: 7.x-1.0-alpha4 » 7.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new navbar_Disable+colliding+modules+in+hook_install.patch589 bytes

Patch attached

hass’s picture

hass commented
Priority: Critical » Major
Status: Needs review » Needs work

This may needs work. I see overlay is supported under D8, so it should work. We just need to fix the offset here for overlay. However toolbar module should be disabled.

jessebeach’s picture

jessebeach commented
Status: Needs work » Closed (fixed)

I think the best way to approach this to mention in the README that this module is incompatible with Toolbar. We shouldn't be disabling modules from this module. There are several modules this could clash which out in contrib space, too.

I added this note in 7.x-1.x (1cd3fd252d00572c307062580aef011c377a2563).

hass’s picture

hass commented
Status: Closed (fixed) » Closed (won't fix)

Ok.

hass’s picture

hass commented
Issue summary: View changes

Updated issue summary.