Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
8 Mar 2013 at 23:50 UTC
Updated:
27 Sep 2018 at 13:10 UTC
Jump to comment: Most recent
Comments
Comment #1
rerooting commentedPhase II wants to use this project in OA 2 alpha, so it would be awesome if we could get this moved to full project status soon!
Comment #2
arun ak commentedHi rerooting,
Please specifiy Version of your project and not found README.txt file in your git repo.
Comment #3
rerooting commentedOops! I'll be pushing a few commits today, will do. First time :)
Comment #4
rerooting commentedWe should be in better shape now. Let me know if I need anything else, thanks! (p.s. I can't figure out how to drop the master branch, I hope that's ok? What do you suggest doing to drop the master branch?)
Comment #5
shadcn commentedHi, Richard (@rerooting) is building a team around this project. He added talengix, niccolo and me as a co-maintainer for the project. We'd like to promote the sandbox to full project and help with development.
See #1956236: Moving forward.
I see that I can promote the sandbox but I'd like to check if it's ok here first.
Comment #6
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxrerooting1890090git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #7
shadcn commentedFixed reported errors by PARview.
Comment #8
rerooting commentedSubmitted some more ctools style plugin changes and a new plugin entirely, works splendidly, and PAReview passed with flying colors!
Comment #9
klausiRemoving review bonus tag, you have not listed any reviews of other projects in the issue summary. Please read #1410826: [META] Review bonus again.
Comment #10
kscheirerYou should remove the .gitignore file from your repo and your plugin styles all have bare PHP at the top of the file. I'm not sure where those belong, but in general that's not allowed in Drupal. Otherwise the code looks great.
----
Top Shelf Modules - Enterprise modules from the community for the community.
Comment #11
kscheirerYou have more than a few errors reported at http://ventral.org/pareview/httpgitdrupalorgsandboxrerooting1890090git.
arshadcn is already a Git Vetted User and can promote this project to full status (feel free to do so, the project looks good). Most of the commits appear to be from that user. If the application is from rerooting, we need to see commits from that person. I'm not sure who the "TPC Staging" git user is - I assume that's related to Triangle Park Creative.
Once their first application has been successfully approved, then an applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue.
With this in mind, I have marked your application as 'closed(duplicate)'. If this is incorrect, then please feel free to re-open this application.
----
Top Shelf Modules - Crafted, Curated, Contributed.
Comment #12
shadcn commentedKarl, thanks for the review.
Actually, this application was for @rerooting. I was helping a bit.
We didn't promote the project because @rerooting wanted to make sure he get git-approved first.
Thanks again :)
Comment #13
kscheirerThanks for the info! I'm not sure why rerooting doesn't show up at all under https://drupal.org/node/1890090/committers. But looking through the actual code commits it seems like most of it belongs to Bob and TPC Staging - which I'm assuming are both rerooting. Arshadcn's commits mainly deal with whitespace and formatting issues.
Comment #14
kscheirerThanks for your contribution, rerooting!
I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
----
Top Shelf Modules - Crafted, Curated, Contributed.
Comment #16
avpaderno