Always allow entity id for EntityDrupalWrapper

Marking #2183095: Countries entity implementation may be wrong; fails if countries are Organic Groups as a duplicate as they sound similar, albeit that I have no idea about the internals.

Steps to replicate are:

1) clean install of the latest Drupal
2) dev versions of OG, Entity, and Countries
3) use the OG Field configuration page to add a "group" field to the country entity, then set one or more countries to be groups.
4) go add an entity reference field to a content type, and make it use the OG widget. Choose the country you set as a group and click save.

The resulting error message on save.

EntityMetadataWrapperException: Invalid data value given. Be sure it matches the required data type and format. in EntityDrupalWrapper->set() (line 736 of /var/www/clean/sites/all/modules/entity/includes/entity.wrapper.inc).

The original reporter has stepped through the code a bit, but not sure if that would shed any more light on the issue

2: 0001-Entity-Issue-1937856-Added-Always-allow-entity-id-fo.patch queued for re-testing.

I haven't the time to setup / check, but a workaround within the countries module could be to define the country name key type in countries_entity_property_info_alter(). No idea of the format, so start with the devel debug:

dpm($info['country']['properties']['name']);

if set, add this:

$info['country']['properties']['name']['type'] = 'string';

Note that the token type fails as the module uses the ISO standard of using Uppercase and the token validation is the Drupal default of validating the machine codes lower case char followed by * lowercase chars, numbers or underscores :/

Please comment in the "duplicate" thread if this works and I'll throw that patch into the module and also mark this as fixed ;)

Note, it was the iso2 column that needed to be altered:

$info['country']['properties']['iso2']['type'] = 'text';

This relaxes the validation allowing uppercase characters / cid to be saved at least. It was defaulted to token / aka a Drupal machine name default validation.

There is still an outstanding issue in that the ER widget is using the ID (cid) entity key rather than the NAME (iso2) entity key, and once things hit the Entity API system, the validation appears to be set to use the NAME entity key.

PS: This is all based on hearsay, I am assuming Entity Reference and not something custom to OG as the root cause here ;)

I have everything latest updates but still getting this error while writing comment to blog or forum.

EntityMetadataWrapperException: Unable to get the data property format as the parent data structure is not set. in EntityStructureWrapper->getPropertyValue() (line 438 of /home6/cusatalu/public_html/sites/all/modules/entity/includes/entity.wrapper.inc).

Here is the code:

 protected function getPropertyValue($name, &$info) {
    $options = array('language' => $this->getPropertyLanguage(), 'absolute' => TRUE);
    $data = $this->value();
    if (!isset($data)) {
<strong>Line no 438 -->    </strong>  throw new EntityMetadataWrapperException('Unable to get the data property ' . check_plain($name) . ' as the parent data structure is not set.');
    }
    return $info['getter callback']($data, $options, $name, $this->type, $info);
  }