Closed (won't fix)
Project:
Drupal core
Version:
8.0.x-dev
Component:
edit.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
9 Mar 2013 at 12:37 UTC
Updated:
29 Jul 2014 at 22:00 UTC
For most forms, the submit buttons are placed on the bottom of the form. For inline edit forms, this "Save" button is shown on the top of the form. This can cause confusion when the inline edit form is shown on top of an other form. In my case the submit buttons for the form underneath it were displayed exacatly below the inline edit form.
Steps to reproduce:
- Install Drupal 8 using the standard profile.
- Create an article node (or any node that allows to place comments on the same page), fill in a title and one line of text in the body field.
- On the node page (for example: node/1), activate "Quick edit" for the body field end inline edit the body field.
Result: the submit buttons of the comment form are exactly placed below the inline edit form, causing confusion.
See also the following image:
| Comment | File | Size | Author |
|---|---|---|---|
| inline-edit-form-save-button-placed-inconsistently.png | 53.26 KB | megachriz |
Comments
Comment #1
wim leers1) This will be mitigated by the fact that soon you'll have CKEditor for editing this in-place :)
2) We used to have an "overlay" on top of all other content exactly to make this kind of thing clear, but people found that bad for reasons I can't remember. Yet it existed precisely to fix this UX problem.
3) The "save" button is *not* placed inconsistently, it's *always* in the same location. It's different from non-in-place editing forms, sure, but for good reason, and it's always consistent.
Comment #2
wim leersComment #3
megachriz1) Okay, I don't yet see how that would solve this usability issue, but then again, I haven't followed the CKEditor issues in the Drupal Core issue queue yet.
3) OK. I was looking at D8 for the first time and noticed that most forms had submit buttons on the bottom, but not the inline edit forms. Anyway, I expected them to be at the bottom, probably because I was used to that in D6 and D7.
Comment #4
wim leersNow listed at #1991702: [meta] Essential UX cleanup of Quick Edit.
Comment #5
Bojhan commentedI am going to postpone this, I am pretty sure CKEditor will solve this. We will know by sure when it works on everything.
Comment #6
wim leersI'm 99% certain that this is going to be fixed as part of #1678002: Edit should provide a usable entity-level toolbar for saving fields: the entity toolbar follows you around there, so it's going to be much more obvious there. For non-sighted users, this was never a problem to begin with, since their tabbing is constrained to relevant elements only. Besides, the fact that this issue only applies to the visual modality is glaringly obvious in the issue title already :)
So: closing!