There are several code style problems with image.schema.yml, keys shouldn't have quotes at all, and values should have single quotes instead of double quotes.

CommentFileSizeAuthor
#5 drupal-image-config-schema-code-style-fix-1938158-5.patch2.23 KBmegachriz

Comments

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: +Configuration system, +D8MI, +language-config, +Configuration schema

Tagging it up.

megachriz’s picture

megachriz
Primary language Dutch
commented
Assigned: Unassigned » megachriz

I'll take a look, though I'm completely new to yml.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Fix code style of image schema » Fix code style of image module configuration schema
Assigned: megachriz » Unassigned
megachriz’s picture

megachriz
Primary language Dutch
commented
Assigned: Unassigned » megachriz
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Active » Needs review
StatusFileSize
new drupal-image-config-schema-code-style-fix-1938158-5.patch2.23 KB

If I understood the issue well, then this patch should fix the code style issue.

megachriz’s picture

megachriz
Primary language Dutch
commented
Assigned: megachriz » Unassigned

Forgot to unassign.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Patch looks good. tnx @MegaChriz

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Thanks, this was one of the first conversions so it's possible we didn't know best practices back then. :)

Committed and pushed to 8.x!

Automatically closed -- issue fixed for 2 weeks with no activity.