Menu router has some issues (dead and incorrect paths), as well as stylistic inconsistencies.

CommentFileSizeAuthor
#1 media_mover_menu_router_fixes-1938562-1.patch16.38 KBiva2k

Comments

iva2k’s picture

iva2k commented
Status: Active » Needs review
StatusFileSize
new media_mover_menu_router_fixes-1938562-1.patch16.38 KB

Here's a patch that addresses those issues. Few notes:

  1. Moved "Add" configuration item under /configuration/add path and MENU_LOCAL_ACTION. It will be listed on the same level as export/import in mm_export, and consistent with other Drupal UX conventions
  2. files list items consolidated and organized
  3. Some paths changed to MENU_NORMAL_ITEM so they don't show up as tabs unexpectedly
  4. @todo notes added where implemmentation or link is missing and it makes sense to fix later.
  5. link to export configuration resurrected
  6. mm file edit link made to return to the view it came from.

I don't expect this patch to apply cleanly as there might be dependencies on other patches currently in 'needs review' state. Posting anyway as I'm about to wrap up any activity in Media Mover and move on to other projects.

Status: Needs review » Needs work

The last submitted patch, media_mover_menu_router_fixes-1938562-1.patch, failed testing.

arthurf’s picture

arthurf commented
Status: Needs work » Closed (fixed)

Committed with some code comments removed, cruft removed, and some code style cleanup.