Follow up for 9 in #1935022-21: Add a language selector on views

Problem/Motivation

Name, description, *and* tag and language are under the edit name/description button.

Proposed resolution

Use a label that better indicates what is in that edit form.

Remaining tasks

  • Discuss what a better label would be.
  • Discuss if this is won't fix.

User interface changes

Change button label.

API changes

No API changes.

CommentFileSizeAuthor
#16 Screenshot_3_19_13_9_12_AM.png6.02 KBgábor hojtsy
#9 basic.png84.9 KByesct
#6 views-to-panel-ui.png51.67 KBvijaycs85

Comments

yesct’s picture

yesct commented

[copied from original issue]

9. the view

s03-the_view.png

10. edit the name to change the language

that is .. strange. will need to change the button to name/description/language? that's a little long for a button name. it's also the place to change the tag.
Lets change the button to something like: change the overall view information. Hm. I'll think more on that in a bit.

s04-the_language_select.png

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Now it at least provides some examples of what it lets you edit. If we change it to some general label, then it would be more accurate, but likely give people less of an idea(?)

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

On the other hand if we make it "edit view name/description/language/tags" that sounds too specific, long, hard to read due to the slashes, etc.

dawehner’s picture

dawehner
Primary language German
commented

I think changing the human name feels like the most used action in there, so what about "Edit name and additional information" or "Edit name and others".

yesct’s picture

yesct commented

"Edit name and overall information" or "Edit name and general information" ?
This is reminding me of panels. I wonder what panels was using for this type of info group.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
StatusFileSize
new views-to-panel-ui.png51.67 KB

@YesCT, I don't see similar situation in current panel pages. But I think we can provide exact panel layout to views to make it more consistent. Sure, this is not the issue for this change. But we can consider for 9.x may be?
views-to-panel-ui.png

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

@vijaycs85: Not related at all to this, yeah.

damiankloip’s picture

damiankloip commented

We could call this 'view metadata' or something instead? That is vague enough and descriptive of what it is too. Just an thought..

yesct’s picture

yesct commented
StatusFileSize
new basic.png84.9 KB

I was thinking there was a tab on the side, Basic has name and description and some other things.

basic.png

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

@damiankloip: I'm not sure obscuring name and description under "metadata" is a good idea, I think that is worse than not including all the elements that are possible to edit and lead with common ones only. My opinion :)

damiankloip’s picture

damiankloip commented

Yeah, you're probably right :) I was just putting it out there. I'm just not a UI kind of guy...

yesct’s picture

yesct commented
Issue tags: +needs initial patch

lets get a patch to experiment with.

first pass: make it say:
edit view name/language/tags/description

---

(Note the field title says: View tag
and it's really View tags
is it worth it's own (novice) issue?

there might be another issue somewhere to make the edit view name... and the other buttons like: view Page
into Capitalized action words. Maybe linked from: #421118: [Meta] Standardize capitalization on actions

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

I don't think we need that many different issues :) These are small tiny things :) Can we fix them here? :)

yesct’s picture

yesct commented

I'm ok with that. :)

hass’s picture

hass commented

YesCT: you must run an outdated dev version... We already fixed the ucfirst bugs in views in #1496418: Views: Don't change capitalization of translatable strings with CSS.

How about "Edit view" or "Edit details"?

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
StatusFileSize
new Screenshot_3_19_13_9_12_AM.png6.02 KB

@hass: I'm running Drupal core as of 19 hours ago (no new commits landed since then). #1496418: Views: Don't change capitalization of translatable strings with CSS seems to be RTBC for over a month now and does not seem to touch these operations:

Screenshot_3_19_13_9_12_AM.png

(All the sub-operations in the dropdowns are also lowercased).

damiankloip’s picture

damiankloip commented

Seems like we should rename this issue now, as it's going to clean up some views UI strings generally?

hass’s picture

hass commented

Dries commited the D8 version on Feb 15 http://drupal.org/node/1496418#comment-7070890 and the strings have been ucfirst in D7. Let's look into the strings again. :-(

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Well, it is definitely not uppercase on these operations yet. Since this issue proposes the label of the button changes anyway, looks like logical to couple the two in here.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 8.6.x-dev » 8.9.x-dev
Issue summary: View changes
Issue tags: -needs initial patch

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Issue tags: -D8MI, -VDC, -SprintWeekend2013

Removing old issue tags. The issue ist still relevant for Drupal 9 / 10.

Perhaps it would make sense to combine the solution with #3267129: Show views original language on edit form and show the language, description and tags below the title in the views edit ui with a link to edit them?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Related issues: +#3212759: Ensure views Translate tabs are visible when editing, +#3267129: Show views original language on edit form

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.