Hello,

I am having the below notice with the Email change confirmation module (doesn't prevent the email from being changed though) :
Notice: Undefined variable: smtp_from in email_confirm_build_mail() (line 321 of /home/www/unilogon/sites/all/modules/email_confirm/email_confirm.module)

I have found a similar issue on a D7 for an email-verify proposal : http://drupal.org/node/1109444

Any suggestion?

CommentFileSizeAuthor
#5 email_confirm_undefined_smtp_from_D7-1938844-5.patch549 bytesmarcoscano
#4 email_confirm-undefined-smtp_from-1938844-3.patch618 bytesbalajidharma
#3 email_confirm-undefined-smtp_from-1938844-3.patch0 bytesbalajidharma
#1 email_confirm-undefined-smtp_from-1938844-1.patch549 bytesbalajidharma

Comments

balajidharma’s picture

balajidharma
Primary language English
commented
Title: Similar Notice on undefined smtp_from looking like one found in http://drupal.org/node/1109444#comment-5704626 » undefined smtp_from in email_confirm_build_mail
Version: 7.x-1.1 » 7.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new email_confirm-undefined-smtp_from-1938844-1.patch549 bytes

I added patch for this issue.

jaydub’s picture

jaydub commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Needs review » Patch (to be ported)

Makes perfect sense. committed and status set to 6.x branch to port

balajidharma’s picture

balajidharma
Primary language English
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new email_confirm-undefined-smtp_from-1938844-3.patch0 bytes

ignore this

balajidharma’s picture

balajidharma
Primary language English
commented
Issue summary: View changes
StatusFileSize
new email_confirm-undefined-smtp_from-1938844-3.patch618 bytes

I added patch for drupal 6.

marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
commented
Version: 6.x-1.x-dev » 7.x-1.1
StatusFileSize
new email_confirm_undefined_smtp_from_D7-1938844-5.patch549 bytes

This issue is present also in the D7 version of the module.

Attaching the corresponding patch.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Version: 7.x-1.1 » 7.x-1.x-dev
Status: Needs review » Fixed

@marcoscano - it was fixed in 7.x-1.x (dev branch) and was released in the 7.x-1.2 version at https://www.drupal.org/project/email_confirm/releases/7.x-1.2

So, I'll move this to "fixed" on the 7.x-1.x-dev branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.