Will boost page load performance.

CommentFileSizeAuthor
#4 masonry-1939114-4-use-behaviours.patch5.04 KBgapple
#1 masonry-use-js-behaviors-1054616-0.patch5.02 KBih2502mk

Comments

ih2502mk’s picture

ih2502mk commented
StatusFileSize
new masonry-use-js-behaviors-1054616-0.patch5.02 KB

Not sure if it will give that amount of increase to page load speed, but it definitely will improve developer experience. Because I've been scratching the back of my had trying to guess, how masonry gets attached to the view if there is no js in this module.

A patch adds a js file to masonry_views submodule and changes the way options are transferred to javascript (i.e. use Drupal.settings).

I would suggest the author of this project to reach out to author of views_fluidgrid project to join forces.

gapple’s picture

gapple
he/they
Primary language English
commented
Status: Active » Needs review

Marked #1933200: Not getting re-applied after AJAX sort? as a duplicate, since Masonry seems to be correctly applied after an AJAX update to a view with this patch applied.

gapple’s picture

gapple
he/they
Primary language English
commented

Marked #1961986: Exposed filters as a duplicate

gapple’s picture

gapple
he/they
Primary language English
commented
StatusFileSize
new masonry-1939114-4-use-behaviours.patch5.04 KB

Updated patch against 7.x-1.x-dev

Also includes small selector change that should address #1942400: Views field view ( view in view) also get masonry item property

Anonymous’s picture

Anonymous (not verified) commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Needs review » Fixed

The upcoming 2.x version of Masonry uses an external file instead of inline javascript, so that should address this issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

dobe’s picture

dobe commented
Version: 7.x-2.x-dev » 7.x-2.0
Status: Closed (fixed) » Active

Hmm. Maybe I shouldn't reopen this but I am running into an issue that is similar to this problem. When using views ajax. The new content does not get the .masonry-brick or the attached style to the items. So it just overlaps everything and sits on the left side.

I am using masonry api 2.0 and masonry_views 1.0.

jquery 1.7

Is there something I am missing here?

Thanks in advance.
-Jesse

dom.’s picture

dom. commented
Issue summary: View changes
Status: Active » Closed (fixed)

This issue has been commited to 2.x years ago.
(Closed as part of clean up by new maintainer).