Not sure if this is a Contextual links issue, or IPE, or Panels or Panelizer...

Anyway to replicate the problem:

1. Klick the IPE edit button on an Panelized page.
2. Click save.
3. The Contextual link on any item will have the "destination" query param set to panels/ajax/ipe/save_form/panelizer:node:23:page_manager

The whole url looks like:
http://mysite.local/en/information#overlay=sv/node/31/edit%3Fdestination...

What happens is that after you save that content you will end up on panels/ajax/ipe/save_form/panelizer:node:23:page_manager that will print json data to the browser.

CommentFileSizeAuthor
#6 1939360-6.patch1.13 KBAngry Dan

Comments

gmclelland’s picture

gmclelland commented

This might be related to this issue - see #1621014: Contextual links and other JavaScript behaviors on panes don't work after clicking "Cancel" in IPE?

gmclelland’s picture

gmclelland commented

I can confirm this is still an issue and the #1621014: Contextual links and other JavaScript behaviors on panes don't work after clicking "Cancel" in IPE is completely separate issue.

Raumfisch’s picture

Raumfisch commented

I can also confirm the described error as well as #1621014 is still present. Is there any progress in in this issue?

roam2345’s picture

roam2345 commented

This is effecting us as well.

For us its polls, when we add a poll to the page and then click on the vote widget we get redirected to a page (panels/ajax/ipe/save_form/panelizer%3Anode%3A3%3Afull) full of json,

adamsro’s picture

adamsro commented
Issue summary: View changes

So when the panel is saved and re-rendered on panels_renderer_ipe.class.php:288 it makes a call to drupal_get_destination in contextual.module which uses $_GET['q'] as the destination, in this case the ajax callback instead of the page url.

As a temporary hack I've added $_GET['destination'] = ''; above panels_renderer_ipe.class.php:288 which will redirect to the home page, but at least saves the panel contents correctly.

To do it right I think we'll need to print the pages url somewhere around the ipe buttons and send it with the ajax call. I might work on a patch for this soon.

Angry Dan’s picture

Angry Dan commented
Version: 7.x-3.3 » 7.x-3.4
Status: Active » Needs review
StatusFileSize
new 1939360-6.patch1.13 KB

See attached patch.

The simplest way I could see to fix this was to just set a destination on the original links, then everything follows through nicely from there. No hacks needed.

adamsro’s picture

adamsro commented

Works, gj. I'm a bit disappointed I missed that.

Angry Dan’s picture

Angry Dan commented
Status: Needs review » Reviewed & tested by the community

This is working for adamsro and I've had it in production since I wrote the patch, so I'm saying RTBC, unless anyone wants to object?

Vegan4Life’s picture

Vegan4Life commented

The patch in #6 works perfectly for me as well. Thanks a lot! I've been having this issue for months.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-3.4 » 7.x-3.x-dev
Issue tags: +panelizer

Tagging this issue.

japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed

Looks good to me. Committed.

  • japerry committed c3d763f on 7.x-3.x authored by Angry Dan 
    Issue #1939360 by Angry Dan, adamsro: After saving a page after editing...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.