Merge Leandro's jQuery Lightbox code
bennybobw - November 21, 2007 - 01:26
| Project: | jQuery Lightbox |
| Version: | 5.x-1.x-dev |
| Component: | JavaScript |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Jump to:
Description
I'm just checking to make sure, but there's a jquery lightbox plugin here: http://leandrovieira.com/projects/jquery/lightbox/
I'm assuming this is a separate project? Or is this module simply using a different version?
Thanks for the info.
#1
(Un)fortunately, there are several variants of Lightbox ports to jQuery. AFAIS, the one you mentioned is not a Drupal module and does not integrate with other Drupal modules. However, if time permits, I'll try to merge all improvements of that the mentioned variant into jLightbox.
#2
It looks rather trivial to take the code from your module to use the plugin I mentioned above (because I need the improvements for a site I'm launching soon). I wouldn't want to start making a bunch of different drupal / lightbox modules though.
What do you think about this?
#3
As I mentioned before, this is already on the task list for jLightbox. As you can read in the project description, the current javascript is based on Warren Krewenki's first draft (v0.20) and has been developed further. It already includes all changes and fixes of Warren's v0.30 and v0.40.
This means that Warren's version and the version in jLightbox are almost the same (jLightbox includes some more bug fixes due to user reports).
Please bear in mind that, until now, jLightbox has tried to stay as comparable as possible to the original Lightbox script written by Lokesh Dakar. This assures that jLightbox can benefit from improvements by Warren, Lokesh, and of course improvements by jLightbox users. So, if you create a diff between those three variants, you are still able to merge any improvements into jLightbox. This allows to include any further improvements.
I wasn't yet able to look at Leandro's jQuery Lightbox code. Basically, there are two options: Either it is written similar to jLightbox and any improvements can be merged into the current jLightbox script, or it's a completely different script that leverages more functions of the jQuery framework. As published in the jLightbox project description, I'm all open for shipping jLightbox with an experimental script that is based on jQuery only.
If you would like to have a stab at this, feel free to post a patch against jLightbox. Because of that, I'm turning this issue into a task.
#4
Here is a free lightbox code generator... http://www.lightboxcodegenerator.info
You can use this free program to select what images you want and it spits out the code for you to copy and paste..