Using $form_state['redirect'] conflicts with other modules (e.g., login toboggan) that may set a post-log-in destination. There's no need for this module to override it.

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

The code comment references #648450: No e-mail verification required autologin.

I don't have a strong feeling about including the redirect as long as the immediate login works.

It's also pretty well known that this module and logintoboggan have issues together (though the latest release of this module should have improved the situation).

Patch (with confirmation that it doesn't break immediate login) very welcome :)

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Re logintoboggan in general - see #738134: Conflict with LoginToboggan submit handler.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Active » Closed (works as designed)

If someone wants to re-open and provide a patch please do.