Hello,
i'm facing this strange behaviour using a taxonomy reference field (multiple values) with autocomplete deluxe.
I have a list of nodes showed by a view with administrative links on each one (edit, delete etc).
If i edit a node from here, delete some values of the field, then add other values (not new terms, but picked from the select box or even by typing+comma), save the node,randomly those values are not saved.
Sometimes if i enter 2 values, 1 is saved and the other is not, or they are not saved at all.
No errors anywhere, node gets saved but without the changes.
It seems like that if i edit the node not from the view but coming from the normal administration content page, this does not happen (i still have to fully verify this though, it has been noticed by a user, but i dont think it is really relevant).

Some clues about what could happen here?
Thank you very much
Mik

CommentFileSizeAuthor
#9 autocomplete_deluxe-delete-issues-1940646-9.patch541 bytesgirish-jerk
#3 autocomplete_deluxe-delete-issues-1940646-3.patch562 bytesbsevere

Comments

zikaelismik’s picture

zikaelismik commented
Issue summary: View changes

More explanation

bsevere’s picture

bsevere commented
Priority: Major » Normal

I can verify this behavior. In my environment we see the problem when adding and deleting new terms in a multiple value field.

To duplicate:
1. edit content that contains an autocomplete_deluxe field
2. add two terms to autocomplete_deluxe field
3. delete the first added term
4. save the content

Result:
No new term is added to the content in the autocomplete_deluxe field

Only newly added terms are affected.

UPDATE:
I can now confirm that the issue does affect existing terms as well. If you delete the first term in the field then only that term will be removed. However, if you remove the second term the second and third term will be removed.

bsevere’s picture

bsevere commented
Priority: Normal » Major

Setting priority to major.

bsevere’s picture

bsevere commented
Priority: Normal » Major
Status: Active » Needs review
StatusFileSize
new autocomplete_deluxe-delete-issues-1940646-3.patch562 bytes

OK. Here is a proposed patch for the issue. It is very simple as it only adds double quotes to the the regex replacement on line 298 of the js file. Please test.

dozymoe’s picture

dozymoe commented

Possibly related #2044951: autocomplete_deluxe can't have more than one field on the same form

If it does can you test the patch there and mark it "reviewed and tested"?

therobyouknow’s picture

therobyouknow commented

Recently it seems to be working OK (without applying your patch) but I would still like to try your patch and report back... thank you for your efforts

bsevere’s picture

bsevere commented

@dozymoe I have not noticed the behavior you mention in the other issue but I am also not using the same release. There have been a couple of code changes since then. I plan to reevaluate this module in the near future by updating to the latest release and trying to recreate the issue in #1. At that time I can also check for the problem you reported. Right now the module is working great with multiple instances on the same form using release 7.x-2.0-beta2+22-dev and my patch in #3.

bsevere’s picture

bsevere commented
Issue summary: View changes

More info added

saranya ashokkumar’s picture

saranya ashokkumar commented
Issue summary: View changes

Hi,
I reviewed the patch #3 and its working fine for me. As per the scenerio #1.
I have faced another issue with the following aspects:

Example:
If I add terms like
1) "Foot Ball"
2) "Foot"
3) "Ball"
If I delete the term "Foot" (term 2) and saved that content. Its get deleted with "Foot" in first term.

Result is "Ball" (term 1) , "Ball" (term 3)

saranya ashokkumar’s picture

saranya ashokkumar commented
Status: Needs review » Needs work

Moving to needs work for #7

girish-jerk’s picture

girish-jerk commented
Status: Needs work » Needs review
StatusFileSize
new autocomplete_deluxe-delete-issues-1940646-9.patch541 bytes

Hi,
I have Created updated patch. This patch will get fix with scenario #1 and #8.

revathi.b’s picture

revathi.b commented
Status: Needs review » Reviewed & tested by the community

#9,worked fine.

LNakamura’s picture

LNakamura commented
Status: Reviewed & tested by the community » Closed (cannot reproduce)

Hi, all - with the latest 2.x dev release, I see neither the behavior described in #1 nor #7. (We've pushed some fixes recently which may have already fixed the problems - or they were fixed earlier, I'm not sure.)

Therefore, I'm closing this issue. If you still see any of the above behavior with the latest 2.x dev release, please let me know and I'll be happy to re-open this issue and we'll go from there.

Thanks!