Our google appliance is in an protected environment and access are restricted with to only allow authenticated cURL calls. This protection is named "cookie cracking" and needs the users cookie in the google appliance call, which then gets checked by google appliance. The check can be handled by our custom module, but we need to add the cookie information to the cURL call of the google_appliance module. In order to make this modular, I suggest a hook to alter the options for the cURL call.

CommentFileSizeAuthor
#10 google_appliance-alter_curl-1940726-10.patch1.91 KBbkonetzny
#9 google_appliance-alter_curl-1940726-9.patch1.79 KBbkonetzny
#6 google_appliance-alter_curl-1940726-6.patch1.79 KBbkonetzny
#1 google_appliance-alter_curl-1940726-1.patch755 bytesbkonetzny

Comments

bkonetzny’s picture

bkonetzny commented
StatusFileSize
new google_appliance-alter_curl-1940726-1.patch755 bytes

Attached patch.

bkonetzny’s picture

bkonetzny commented
Status: Active » Needs review
iamEAP’s picture

iamEAP commented
Status: Needs review » Needs work

Seems fine to me.

For completeness, this should also include some documentation in google_appliance.api.php.

mpgeek’s picture

mpgeek commented

@bkonetzny, i would concurr here that API changes should be documented in google_appliance.api.php before we commit this one. Thanks.

bkonetzny’s picture

bkonetzny commented
Assigned: Unassigned » bkonetzny

Didn't know about this, I'll provide an updated patch in the next days.

bkonetzny’s picture

bkonetzny commented
Assigned: bkonetzny » Unassigned
Status: Needs work » Needs review
StatusFileSize
new google_appliance-alter_curl-1940726-6.patch1.79 KB

Added documentation in google_appliance.api.php.

iamEAP’s picture

iamEAP commented

Looks good. +1 from me.

Thanks @bkonetzny

mpgeek’s picture

mpgeek commented

@bkonetzny, it does look good, thanks for documenting. However git is telling me the patch is corrupt. Did you roll this against the latest stable or against dev? I have both whitespace and "cant' find" errors.

bkonetzny’s picture

bkonetzny commented
StatusFileSize
new google_appliance-alter_curl-1940726-9.patch1.79 KB

Hmm, that's weird. Patch is for latest dev of 7.x-1.x.

bkonetzny’s picture

bkonetzny commented
StatusFileSize
new google_appliance-alter_curl-1940726-10.patch1.91 KB

Ok, now I created the patch following the steps from http://drupal.org/node/244140/git-instructions/7.x-1.x

mpgeek’s picture

mpgeek commented

@bkonetzny, that's the ticket. Committed to dev: http://drupalcode.org/project/google_appliance.git/commit/223d10

mpgeek’s picture

mpgeek commented
Status: Needs review » Reviewed & tested by the community
iamEAP’s picture

iamEAP commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

FYI, this is available as of Google Appliance 7.x-1.12.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.