How to include Domain Access in my install profile ?

I think you have to do that outside of Drupal, actually. Do you have a build script? I use this bash script as part of my local setup:

# add setup to settings.php
chmod 775 sites/default/settings.php
echo >> sites/default/settings.php
echo "\$cookie_domain = '.example.com';" >> sites/default/settings.php
echo >> sites/default/settings.php
echo "include DRUPAL_ROOT . '/sites/all/modules/domain/settings.inc';" >> sites/default/settings.php;
chmod 664 sites/default/settings.php

You can safely add these lines to settings.php before installing the module. The module is smart enough not to fire if it is not enabled.

See also #1823190: Do not create default domain on installation, which is related if not identical.

Wrapping the include call in a conditional should be fine. It is not recommended because it would, in many cases, confuse people.

We could also move the IF to the DOMAIN_BOOTSTRAP_INIT phase of _domain_bootstrap(). Currently, we assume a database has been installed.

We could at least ensure that $databases is not empty. I think there is a separate issue for disabling the auto-creation of a default domain.

How about we use some other $conf flag here then?

Oooo. Fancy, but sounds good. That code was originally written in Drupal 5 ;-)

I think you mean _your_ patch ;-)

Well, if the database is not instantiated, db_query() won't load, so this small patch works.

We might also do a try/catch in addition.

Here's a version with both.

I don't quote understand the error you're getting. The patch above should short-circuit any Domain loading. The error you are now reporting sounds like a Drush issue.

Are you getting any errors from Domain module code?

Is $new_phase FALSE or TRUE in your case? What happens when you force it to be the other option? (See the comment block from lines 97-102).

I suggest that because we've had issues in the past (documented in the comments) where the $new_phase has to be set specifically based on the calling condition. Right now, we don't account for "installing". So forcing a change there may fix the issue.

i am running into the exact same problem.

my database array has been defined and using drupal_installation_attempted() does not work as the maintenance mode is set in a later stage.

what i am trying to do is to build a deployment script like this so i can run it multiple times on different servers

# Deployment Script

# Set up initial drupal environment
drush si -y local_profile --account-pass="local" --sites-subdir="default"

# enable the domain module
drush pm-enable domain --uri=http://local.com.hk/

See comments 15 and 16 for testing options.

I've added a couple of lines in which checks the global $install_state. If thats populated we don't want to run the bootstrap as the installation isn't complete.

I've tested it locally and it allows you to add in include in your settings file, and have domain access be a dependancy in your installation profile.

Patch #22 still gives me "Fatal error: Call to undefined function db_query().." when trying to install a site.

This worked for me:

Wouldn't db_table_exists() be a better check?

No, because if the function db_query() is not available, neither is db_table_exists().

Makes sense. This needs some review.

I originally applied the patch in #12 to fix issues I had when installing using drush site-install. I needed to also wrap my settings.inc include in my settings.php in an if (!empty($databases)) statement. This worked fine, until I started automatically enabling some features containing domain config, along with enabling the domain module and some additional domain contrib modules.

This caused an "Error: Call to undefined function domain_get_primary_table() " due to the settings.inc not being loaded. Because at that point, settings.php HAD been adjusted with a filled $databases array, but had not been reloaded, and thus the domain bootstrap hadn't been included.

To fix this, I applied the patch from #22 also. I also removed the if (!empty($databases)) statement from my settings.php. This succesfully allowed me to install my site along with the domain config.

Attached is a patch containing fixes from those two commenters, applied against the latest dev. I've also slightly modified the comments in the file to reflect the changes made.

Using $install_state is smart. There is a typo in the comments.

if we're unable to interact with the dabase,

Corrected typo in #28.
The patch tested the latest Domain Access module from Git (7.x-3.x) and Drush 6.x.
Drush commands for testing: sqlc, cron, cc all, pm-enable, sql-dump
The patch works well!
Thanks!

Still works, dare i to ...

Marking for inclusion after some review.

Committed.

Nice work, all.

   36d69e8..e4e8b06  7.x-3.x -> 7.x-3.x

This did not work for me using Drush 7. I had to populate install_state manually in settings.php:

/**
 * Fix site install when using domain module
 */
if (function_exists('drush_get_command')) {
  $command = drush_get_command();
  if ($command['command'] == 'site-install') {
    // This will disable domain module in _domain_bootstrap()
    global $install_state;
    $install_state = array('temp');
  }
}

I have some issues with code of @DuaelFR in #0.

I found another way, based on @andreas-radloff code #37 for the drush install.
And for UI install, MAINTENANCE_MODE is setted, so we don't want to load domain settings. But we load it in our tasks before enabling domain module.

Here is my code which allow to install domain from profile install with UI and drush :

In myprofile.profile file.

/**
 * Implements hook_install_tasks().
 */
function myprofile_install_tasks() {
  return array(
    'enable_domain' => array(
      'display_name' => 'Enable Domain Access',
      'display' => TRUE,
      'type' => 'normal',
      'run' => INSTALL_TASK_RUN_IF_NOT_COMPLETED,
      'function' => '_myprofile_install_enable_domain',
    ),
  );
}

/**
 * Install task "enable_domain" callback.
 * 
 * Add domain specific code inclusion in settings.php.
 */
function _myprofile_install_enable_domain() {
  // Add settings.inc file from domain module.
  module_load_include('inc', 'domain', 'settings');
  // Enable Domain.
  // Add other domains modules here.
  module_enable(array('domain'), TRUE);
}

Here is my settings.php file :

/**
 * Fix site install when using domain module
 */
if (function_exists('drush_get_command')) {
  $command = drush_get_command();
  if ($command['command'] == 'site-install') {
    // This will disable domain module in _domain_bootstrap()
    global $install_state;
    $install_state = array('temp');

    define('MAINTENANCE_MODE', 'install');
  }
}

/**
 * Add the domain module setup routine.
 */
if (!defined('MAINTENANCE_MODE')) {
  include DRUPAL_ROOT . '/profiles/myprofile/modules/contrib/domain/settings.inc';
}

#38 fixed it for me. Thanks GoZ!

Yes #38 fixed it for me too. Thanks @Goz