Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
theme
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
13 Mar 2013 at 17:47 UTC
Updated:
17 Apr 2013 at 19:56 UTC
Jump to comment: Most recent file
Comments
Comment #1
klausiLink to the project page and git clone command are missing in the issue summary, please add them.
We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and put yourself on the PAReview: review bonus high priority list. Then I'll take a look at your project right away :-)
Comment #1.0
klausimisspelling
Comment #2
danny englanderJust wondering IMO, you are already a maintainer of the Professional Theme, wouldn't it be best to keep collaborating over there? If you are looking to get full commit rights, I would design and develop your own theme from scratch and then submit it here, just my 2 cents though.
You may want to look at:
Joining forces with others and co-maintaining projects
That being said, I do get the part about:
... as it relates to these issues and saran.quardz:
#1772284: What are the thresholds for support for a project on drupal.org?
#1670204: obnoxious theme teasers
Comment #3
mheinke commentedyes, 60% of the problem is just the philosophy. the idea that "i wont fix it unless someone pays me.." well why become a project maintainer at all.
the other 40% is i have patches waiting to be committed. after contacting several times im getting no response. so even the work i am putting in does not get pushed live.
i have users and an issue queue and my responses to users are "waiting till the next version" with no knowledge of when this will be. so i just want a clean fork.
sorry im not using this thread as a way to rant, just trying to explain my position.
Comment #4
danny englanderAh, gotcha, well that makes more sense. What irks me is that he just pushed up a new theme up a few weeks ago.
I also submitted a patch to his Premium Responsive theme.
#1670748: Insecure warnings using SSL with Google fonts
... and never heard back from him, nor did he comment later in the issue. He's getting gifts in the form of patches from users like you and me and being belligerent about it. So perhaps either file to get full commit rights for that project or I guess you are justified in forking. You could also claim that he's fully abandoned the project but you'd have to go through the proper channels as such:
Dealing with unsupported (abandoned) projects
Good luck! :)
Comment #5
mheinke commentedthank you for taking a look / reviewing :)
yea i would prefer to fork. just to lose all association (except attribution) with the original.
Comment #6
danny englanderIf it were me, I would take him to task and file an abandoned issue for that theme, it might be a wake up call for him as he's been warned on so many occasions or the powers that be might even take away his commit rights for projects. I just don't know enough about how all this works though, I am just a lowly themer trying to make a livin' and give something back just as you are too.
Comment #7
mheinke commentedthat is how i got the co-maintainer job a month or 2 ago. :)
Comment #8
mheinke commentedComment #9
klausiThere are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxmheinke1942054git
Comment #10
manjit.singhI have done with the UI manual review of your theme in Android, And found some bugs. Please look at it.
1. Add new comment button UI disturbed. Refer screenshot (add new comment button.png).
2. The description of slideshow images has not proper. Refer screenshot (descrption of Slideshow image.png).
3. position of Resize button is not right. Refer screenshot (resize button.png)
Please look at it on Android phone.
Comment #11
manjit.singhFound some more UI bugs in IE9. Please find the attachment for the same.
1. In IE9, width is diffrent for both text fields. Refer scrrenshot (login_text_fields.png).
2. Search image disappear. Refer scrrenshot (search_image.png).
3. In contact-us page, Bottom border radius is disappear in send message button. Refer scrrenshot (send_message_button.png).
4. Unwanted space is coming on buttons. Refer scrrenshot (unwanted space.png).
These all bugs are in IE9 Browser.
Comment #12
mukeysh commentedPlease mention drupal core version in info file like
core = 7.xand add comments in info file for easy readability.Comment #13
Anks commentedSome of Manual reviews
<div id="copyright" style="display:none;">Regards,
Ankit Hinglajia
Comment #14
devsaran commented@mheinke
I am more than happy to receive your commit to my Professional theme. I was actually awaiting and never got a mail notification to release your commit in the Professional theme. Now, I have given you the full permission in my Professional theme to add a new theme release.
Comment #15
mheinke commentedI have decided to not port and just use professional theme
please close
Comment #16
mheinke commentedComment #17
danny englander@mheinke - For the Professional theme itself, you might also want to get rid of his suggested payment links in the .info file and the README.txt files.
Comment #18
devsaran commentedI will remove those links in all my themes.. Sorry for my mistake.
Comment #19
mheinke commentedi adjusted professional_theme
and will remove it from the readme with the next release.
Comment #19.0
mheinke commentedadded link to project and Git Clone