Download & Extend
Issues

Make Filter module active config save format match the default yml file.

Posted by vijaycs85 on March 13, 2013 at 6:13pm
Project:Drupal core
Version:8.x-dev
Component:filter.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (duplicate)
Issue tags:Config novice, Configuration system

Issue Summary

This is a sub-issue of #1938580: [META] Make active config save format match the default yml file (order and quotes). Check meta issue for Steps to reproduce and Coding standards

Files fixed already
filter.settings.yml

Files need to be fixed
filter.format.plain_text.yml

Remaining tasks

Login or register to post comments

Comments

#1

Posted by sandipmkhairnar on March 16, 2013 at 9:52am

I think filter.format.plain_text.yml file looks good. No need to change.

#2

Posted by vijaycs85 on March 16, 2013 at 11:07am
Status:active» needs work

Guess user roles should be removed for this format as there is no option we can change it? Please refer screenshots:
2013-03-16_163624.png

2013-03-16_163608.png

AttachmentSizeStatusTest resultOperations
2013-03-16_163624.png27.99 KBIgnored: Check issue status.NoneNone
2013-03-16_163608.png60.56 KBIgnored: Check issue status.NoneNone

#3

Posted by sandipmkhairnar on March 16, 2013 at 11:29am

Thanks @vijaycs85 for review.

Created patch as per comment.

AttachmentSizeStatusTest resultOperations
1942122-filter-config-format-3.patch449 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 55,400 pass(es).View details | Re-test

#4

Posted by sandipmkhairnar on March 16, 2013 at 11:30am
Status:needs work» needs review

#5

Posted by vijaycs85 on April 10, 2013 at 8:19pm

#3: 1942122-filter-config-format-3.patch queued for re-testing.

#6

Posted by SwapS on April 27, 2013 at 11:06am

#3: 1942122-filter-config-format-3.patch queued for re-testing.

#7

Posted by tim.plunkett on April 28, 2013 at 5:32am
Status:needs review» closed (duplicate)

Actually, those roles values are needed. We have a test for that, if you tried to remove the roles from filter.format.filter_test.yml, this would fail:

http://drupalcode.org/project/drupal.git/blob?f=core/modules/filter/lib/...

These files are being updated as a part of the much larger #1868772: Change notice: Convert filters to plugins, I'm closing this as a duplicate.