This is a version of the patch in comment #8 of Issue #1316194: Add an option to manually load subsequent pages, instead of automatically scrolling based on window scroll rolled against 7.x-1.x-dev (same as 7.x-1.1 at the time of submission).

CommentFileSizeAuthor
#6 views_infinite_scroll_manually-load-next-pages_1316194_d7_6.patch8.72 KBcorbacho
#5 views_infinite_scroll_manually-load-next-pages_1316194_d7.patch8.71 KBjmuzz
views_infinite_scroll_manually-load-next-pages_1316194_d7.patch8.71 KBGloryFish

Comments

hugronaphor’s picture

hugronaphor commented

I applied your patch, and it's working great.
Thanks.

maximilianmikus’s picture

maximilianmikus commented

works fine! Thank you!

kolier’s picture

kolier commented
Status: Active » Needs review

Works well +1.

dafeder’s picture

dafeder
he/him
Location Philadelphia, PA
commented

Working for me as well so far with no issues.

jmuzz’s picture

jmuzz commented
Issue summary: View changes
StatusFileSize
new views_infinite_scroll_manually-load-next-pages_1316194_d7.patch8.71 KB

Very nice, but the text shouldn't be required. I want to give the button an image using a background instead of using text in the link. It would be strange for something in a views form to be required, most of the elements are not, including the text for the buttons in the other pagers.

corbacho’s picture

corbacho commented
StatusFileSize
new views_infinite_scroll_manually-load-next-pages_1316194_d7_6.patch8.72 KB 
+++ b/js/views_infinite_scroll.js
@@ -35,31 +37,50 @@ Drupal.behaviors.views_infinite_scroll = {
+                return false;

return false; in the click handler, is preventing to have any other event listener for the click. I replaced it with e.preventDefault();
The change is on top of the patch of jmuzz (#5)

sam152’s picture

sam152 commented
Status: Needs review » Fixed

This has been added to the dev branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.