This is a sub-issue of #1938580: [META] Make active config save format match the default yml file (order and quotes).

Files need to be fixed
locale.setttings.yml

Files fixed already

CommentFileSizeAuthor
#6 1942148-locale-config-fix-6.patch625 bytesswaps
#6 1942148-diff-2-6.txt567 bytesswaps
#2 1942148-locale-config-fix-2.patch719 bytessandipmkhairnar
#1 1942148-locale-config-fix-1.patch744 bytesvijaycs85

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Active » Needs review
StatusFileSize
new 1942148-locale-config-fix-1.patch744 bytes
sandipmkhairnar’s picture

sandipmkhairnar commented
StatusFileSize
new 1942148-locale-config-fix-2.patch719 bytes

Thanks @vijaycs85. As discussed on IRC updated directory variable.

vijaycs85’s picture

vijaycs85
Location London, UK
commented

#2: 1942148-locale-config-fix-2.patch queued for re-testing.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs review 
+++ b/core/modules/locale/config/locale.settings.ymlundefined
@@ -2,11 +2,11 @@ cache_strings: '1'
   directory: 'languages'

I don't get why the quotes are back?

+++ b/core/modules/locale/config/locale.settings.ymlundefined
@@ -2,11 +2,11 @@ cache_strings: '1'
-  path: ''
+  path: null

Also as we convert everything (atm) to strings... are you sure about this?

swaps’s picture

swaps commented
StatusFileSize
new 1942148-diff-2-6.txt567 bytes
new 1942148-locale-config-fix-6.patch625 bytes

Thanks for Review @alexpott.
Here is the patch.

linl’s picture

linl commented
Status: Needs review » Closed (duplicate)

These changes have been done in #2106459: Core config has everything as string so closing this as a duplicate.