Needs review
Project:
tinynav.js
Version:
7.x-1.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
14 Mar 2013 at 07:31 UTC
Updated:
27 Aug 2014 at 12:02 UTC
Jump to comment: Most recent
Comments
Comment #1
btopro commentedHmm... I'll need a screenshot. Can you remove the "Header" option and see if that helps. Also it's supposed to say "Navigation" which is rewritten by Drupal.t for multi-lingual sites so that's another possibility. I've never had the ability to test the Drupal.t() function as I don't run multi-lingual but that sounds possible given the strange output you are reporting.
Comment #2
arrubiu commentedI solved simply deleting the tinynav library from sites/all/libraries :)
Comment #3
btopro commentedoh... hmm, I wonder if we can't implement the current library given the improvements we've made in the fork... this is worth having a larger conversation about.
Changing title to reflect that this is potentially an issue. We've been given the OK to use the fork'ed library and this last update makes significant changes to more deeply integrate it into Drupal. Maybe it's time to keep branching but I'll let people voice that opinion in the queue
Comment #4
arrubiu commentedFor now I think it could be useful to write, in the readme or in the main page of the module to do not install the "default" library.
Comment #5
hass commentedI'm for removing the fork and use the original only. Do not reinvent the wheel.
Comment #6
btopro commentedunfortunately based on the description it is the original that is causing problems while the fork which takes into account Drupal is not having issues, at least based on issue title / flow
Comment #7
hass commentedI need all these new features in 1.1 like tree and other. The fork is very buggy and broken. We need to find a way to integrate the original library. What's wrong with the original that requires a fork?
Comment #8
btopro commentedYou can still use the original so I'm not sure what the issue is. The fork allows for drupal specific integration points like use of the Drupal translate function for example which the tinynav library assumes to be the word navigation (in the past at least).
Comment #9
hass commentedNot at all. Give it a try snd see how broken it is. I opened several cases with issues about this.
Comment #10
pityu73 commentedHi!
I tested this module I, the indicated error occurred within me.
If you deleted the "sites / all / libraries / tinynav" folder the files then the problem disappeared.
tested versions:
7.x-1.2
7.x-1.x-dev
thanks
Stephen
Comment #11
cdracars commentedThe header is the issue as far as getting the original tinynav.js to function properly... I commented out the header
'header' => $header ? TRUE : FALSE, around line 37 of the module. After doing this the true / false quit adding itself to the menu and options where selected properly.
Comment #11.0
cdracars commentedRemove attachment reference.
Comment #12
btopro commentedThe tinynav drupal module project page says
Unless we patch / fix this in the tinynav project https://github.com/viljamis/TinyNav.js there's not much we can do. Supplying a patch in this queue would be helpful for purists that want to patch their repo via a make file but I haven't looked deeply enough into where the repo has gone since we forked it.
String: Specify text for "header" and show header instead of the active itemWe have support in ours for translatable strings and user defined settings coming from Drupal instead of the library outright.If someone wants to get this in then I'll accept patches but I don't see a gain personally in doing so when the end result is the same.