http://drupal.org/node/191360 equally applies to taxonomy parent/select with large numbers of terms. So I've cloned the implementation for the taxonomy admin pages and the node add form with a different variable.

CommentFileSizeAuthor
#5 taxonomy_override.patch3.03 KBchx
#4 taxonomy_override.patch3.03 KBcatch
#3 taxonomy_override.patch3.03 KBcatch
taxonomy_override.patch3.09 KBcatch

Comments

catch’s picture

catch
he/him
Primary language English
commented

Also it wasn't in the final patch, but somehow the relations select was nuked in the taxonomy ui cleanup, this one puts it back in. I don't mind rolling a one line patch for that, but it's the same chunk of code being affected so included with this for now.

Note that since we now show the parents and relations on taxonomy/term/add pages indiscriminately, including for freetagging vocabularies, this could be a big memory issue loading them. Oh and thanks to chx for irc advice on this.

chx’s picture

chx commented
Status: Needs review » Needs work

Thanks for taking this issue. However, if you put the code inside if (variable_get('menu_override_parent_selector', FALSE)) { then you need to negate if (!. Also, inside functions we only use // as the comments marker.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new taxonomy_override.patch3.03 KB

thanks chx, this one should cover all that.

catch’s picture

catch
he/him
Primary language English
commented
StatusFileSize
new taxonomy_override.patch3.03 KB

one comment wrapped at col 81

chx’s picture

chx commented
StatusFileSize
new taxonomy_override.patch3.03 KB

Um, another ! left out.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Fixed

OK, committed.

moshe weitzman’s picture

moshe weitzman commented

what does taxonomy_override_selector buy us that we could not already do with form_alter?

catch’s picture

catch
he/him
Primary language English
commented

In both of those forms the full taxonomy tree is loaded before form_alter can intercept. So as with the menu choosers, it allows you to insert drilldowns (or whatever) that can circumvent that.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.