Closed (fixed)
Project:
Commerce Kickstart
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
15 Mar 2013 at 11:11 UTC
Updated:
3 Jun 2013 at 12:40 UTC
A small patch that includes a config.rb file, so theme editors don't have to create one.
It also renames scss/mixins.scss to scss/_mixins.scss
and scss/variables.scss to scss/_variables.scss
(and updates scss files that reference them.
This stops compass from generating css files from these include files.
I intend to release another patch that puts all the theme colours in the variables.scss file as sass variables. That way new themers just need to make changes in one place to update their entire theme.
Please let me know if you don't think this is worthwhile doing.
| Comment | File | Size | Author |
|---|---|---|---|
| commerce_kickstart_sass.patch | 8.97 KB | medden |
Comments
Comment #1
bojanz commentedSounds great!
Setting issue status to "needs review" so that someone can commit the first patch later today.
Comment #2
dudenhofer commentedNice patch, I would just disable the line comments and set the output style to :nested to avoid re-writing all of the CSS files every time some one switches between compass watch and sass --watch
Comment #3
dudenhofer commentedSorry, should have marked this differently. But a simple fix ^.
Comment #4
heyyo commentedIf I'm starting from a fresh sub-theme of Omega Kickstart, would I be able to use those SASS files ? Or those files are only usable for overriding the Commerce Kickstart theme ?
Comment #5
dudenhofer commentedI edited the config so it won't completely rewrite all the css files from previous commits.
https://code.drupalcommerce.org/#/c/685/
Comment #6
jsacksick commented