See here: http://drupalcode.org/project/views.git/blob/HEAD:/handlers/views_handle...

if (!empty($field->field_alias) && !empty($field->field_alias)) {
  $fields[] = "$field->table_alias.$field->real_field";
}

I'm not crazy here, right?

CommentFileSizeAuthor
#5 interdiff.txt673 bytesjoelpittet
#5 1944150-5.patch673 bytesjoelpittet
#3 views-duplicateif-1944150-3.patch672 bytesesmerel
#2 views-duplicateif-1944150-2.patch0 bytesesmerel

Comments

dawehner’s picture

dawehner
Primary language German
commented

Right, this should be $field->table_alias. I realized that on another issue, but not sure which one.

esmerel’s picture

esmerel commented
Status: Active » Needs review
StatusFileSize
new views-duplicateif-1944150-2.patch0 bytes

I'm not comfortable committing code changes, so I'm going to make a patch :D

esmerel’s picture

esmerel commented
StatusFileSize
new views-duplicateif-1944150-3.patch672 bytes

Let's try this with a real patch.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

There looks to be another bug here where $field->field_alias is checked but not used in the concatenation... anyways this code is correct.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 1944150-5.patch673 bytes
new interdiff.txt673 bytes

@Lendude pointed out it's kind of silly that it's checking for an field_alias then using the real_field in the D8 version, so here's the patch to make that make a bit more sense. If there was a reason for the other way it should have been explained in a comment.

chris matthews’s picture

chris matthews commented
Status: Needs review » Reviewed & tested by the community

The 2 year old patch in #5 to views_handler_filter_combine.inc applied cleanly to the latest views 7.x-3.x-dev and looks good to me.

  • DamienMcKenna committed 66d1c17 on 7.x-3.x authored by esmerel 
    Issue #1944150 by esmerel, joelpittet, Chris2, dawehner, BrockBoland:...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed
Parent issue: » #2960871: Plan for Views 7.x-3.23 release

Committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.